[PATCH 0/2] ACPI / PMIC: constify platform_device_id

[PATCH 0/2] ACPI / PMIC: constify platform_device_id

[Arvind Yadav]

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Arvind Yadav (2):
  [PATCH 1/2] ACPI / PMIC: constify platform_device_id
  [PATCH 2/2] ACPI / PMIC: Constify platform_device_id

 drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +-
 drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

[PATCH 1/2] ACPI / PMIC: constify platform_device_id

[Arvind Yadav]

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
index 85636d7..813b829 100644
--- a/drivers/acpi/pmic/intel_pmic_chtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
@@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
 			&intel_cht_wc_pmic_opregion_data);
 }
 
-static struct platform_device_id cht_wc_opregion_id_table[] = {
+static const struct platform_device_id cht_wc_opregion_id_table[] = {
 	{ .name = "cht_wcove_region" },
 	{},
 };
-- 
1.9.1

Re: [PATCH 1/2] ACPI / PMIC: constify platform_device_id

[Mika Westerberg]

On Tue, Nov 28, 2017 at 03:31:50PM +0530, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

[PATCH 2/2] ACPI / PMIC: Constify platform_device_id

[Arvind Yadav]

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/pmic/intel_pmic_bxtwc.c b/drivers/acpi/pmic/intel_pmic_bxtwc.c
index 90011aa..2012d1d 100644
--- a/drivers/acpi/pmic/intel_pmic_bxtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_bxtwc.c
@@ -400,7 +400,7 @@ static int intel_bxtwc_pmic_opregion_probe(struct platform_device *pdev)
 			&intel_bxtwc_pmic_opregion_data);
 }
 
-static struct platform_device_id bxt_wc_opregion_id_table[] = {
+static const struct platform_device_id bxt_wc_opregion_id_table[] = {
 	{ .name = "bxt_wcove_region" },
 	{},
 };
-- 
1.9.1

Re: [PATCH 2/2] ACPI / PMIC: Constify platform_device_id

[Mika Westerberg]

On Tue, Nov 28, 2017 at 03:31:51PM +0530, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

You may want to change the title to mention the PMIC driver in question
like: "ACPI / PMIC / bxtwc: ..." or so.

The patch itself is fine,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH 0/2] ACPI / PMIC: constify platform_device_id

[Rafael J. Wysocki]

On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Arvind Yadav (2):
>   [PATCH 1/2] ACPI / PMIC: constify platform_device_id
>   [PATCH 2/2] ACPI / PMIC: Constify platform_device_id

Can you please resend the two changes in this series as one patch?

Thanks,
Rafael

Re: [PATCH 0/2] ACPI / PMIC: constify platform_device_id

[Arvind Yadav]

Hi Rafael,


On Wednesday 29 November 2017 02:28 AM, Rafael J. Wysocki wrote:
> On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
> <arvind.yadav.cs@gmail.com> wrote:
>> platform_device_id are not supposed to change at runtime. All functions
>> working with platform_device_id provided by <linux/platform_device.h>
>> work with const platform_device_id. So mark the non-const structs as
>> const.
>>
>> Arvind Yadav (2):
>>    [PATCH 1/2] ACPI / PMIC: constify platform_device_id
>>    [PATCH 2/2] ACPI / PMIC: Constify platform_device_id
> Can you please resend the two changes in this series as one patch?
Yes, I will resend as single patch.
> Thanks,
> Rafael
Thanks,
~arvind