From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [PATCH 0/2] Provide defines for 104-QUAD-8 magic numbers
Date: Thu, 24 May 2018 16:37:35 -0400 [thread overview]
Message-ID: <cover.1527193661.git.vilhelm.gray@gmail.com> (raw)
Magic numbers can be difficult to understand, and at times hide bugs
that would otherwise be obvious to readers of the source code.
The first patch in this patchset provides a fix for an improperly
selected magic number (an off-by-one error). The second patch adds
defines to remove these magic numbers and thus help make the driver
source code easier to read and debug.
The discovery of the error fixed by the first patch is thanks to these
defines: the improper magic number stuck out like a sore thumb next
to the expected define symbol. So I should have used these defines from
the start.
William Breathitt Gray (2):
iio: 104-quad-8: Fix off-by-one error in register selection
iio: 104-quad-8: Provide defines for magic numbers
drivers/iio/counter/104-quad-8.c | 86 ++++++++++++++++++++++----------
1 file changed, 60 insertions(+), 26 deletions(-)
--
2.17.0
next reply other threads:[~2018-05-24 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 20:37 William Breathitt Gray [this message]
2018-05-24 20:37 ` [PATCH 1/2] iio: 104-quad-8: Fix off-by-one error in register selection William Breathitt Gray
2018-05-27 9:30 ` Jonathan Cameron
2018-05-24 20:37 ` [PATCH 2/2] iio: 104-quad-8: Provide defines for magic numbers William Breathitt Gray
2018-05-27 9:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1527193661.git.vilhelm.gray@gmail.com \
--to=vilhelm.gray@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).