* [PATCH ghak105 V1 0/2] audit: clean up CONFIG_AUDITSYSCALL @ 2019-01-22 22:07 Richard Guy Briggs 2019-01-22 22:07 ` [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs Richard Guy Briggs 2019-01-22 22:07 ` [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL Richard Guy Briggs 0 siblings, 2 replies; 5+ messages in thread From: Richard Guy Briggs @ 2019-01-22 22:07 UTC (permalink / raw) To: LKML, Linux-Audit Mailing List Cc: Eric Paris, Steve Grubb, Paul Moore, Richard Guy Briggs Compiles and boots with config AUDITSYSCALL def_bool n in init/Kconfig. Verified syscall code is not present in resulting kernel. Richard Guy Briggs (2): audit: clean up AUDITSYSCALL prototypes and stubs audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL include/linux/sched.h | 2 +- kernel/audit.c | 155 +++----------------------------------------------- kernel/audit.h | 73 +++++++++++------------- kernel/auditsc.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 190 insertions(+), 188 deletions(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs 2019-01-22 22:07 [PATCH ghak105 V1 0/2] audit: clean up CONFIG_AUDITSYSCALL Richard Guy Briggs @ 2019-01-22 22:07 ` Richard Guy Briggs 2019-01-25 21:56 ` Paul Moore 2019-01-22 22:07 ` [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL Richard Guy Briggs 1 sibling, 1 reply; 5+ messages in thread From: Richard Guy Briggs @ 2019-01-22 22:07 UTC (permalink / raw) To: LKML, Linux-Audit Mailing List Cc: Eric Paris, Steve Grubb, Paul Moore, Richard Guy Briggs Pull together all the audit syscall watch, mark and tree prototypes and stubs into the same ifdef. Signed-off-by: Richard Guy Briggs <rgb@redhat.com> --- kernel/audit.h | 64 ++++++++++++++++++++++++++++++---------------------------- 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/kernel/audit.h b/kernel/audit.h index 6ffb70575082..22ef49b76daa 100644 --- a/kernel/audit.h +++ b/kernel/audit.h @@ -267,25 +267,47 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, extern struct tty_struct *audit_get_tty(void); extern void audit_put_tty(struct tty_struct *tty); -/* audit watch functions */ +/* audit watch/mark/tree functions */ #ifdef CONFIG_AUDITSYSCALL extern void audit_put_watch(struct audit_watch *watch); extern void audit_get_watch(struct audit_watch *watch); -extern int audit_to_watch(struct audit_krule *krule, char *path, int len, u32 op); +extern int audit_to_watch(struct audit_krule *krule, char *path, int len, + u32 op); extern int audit_add_watch(struct audit_krule *krule, struct list_head **list); extern void audit_remove_watch_rule(struct audit_krule *krule); extern char *audit_watch_path(struct audit_watch *watch); -extern int audit_watch_compare(struct audit_watch *watch, unsigned long ino, dev_t dev); +extern int audit_watch_compare(struct audit_watch *watch, unsigned long ino, + dev_t dev); -extern struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, char *pathname, int len); +extern struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, + char *pathname, int len); extern char *audit_mark_path(struct audit_fsnotify_mark *mark); extern void audit_remove_mark(struct audit_fsnotify_mark *audit_mark); extern void audit_remove_mark_rule(struct audit_krule *krule); -extern int audit_mark_compare(struct audit_fsnotify_mark *mark, unsigned long ino, dev_t dev); +extern int audit_mark_compare(struct audit_fsnotify_mark *mark, + unsigned long ino, dev_t dev); extern int audit_dupe_exe(struct audit_krule *new, struct audit_krule *old); -extern int audit_exe_compare(struct task_struct *tsk, struct audit_fsnotify_mark *mark); +extern int audit_exe_compare(struct task_struct *tsk, + struct audit_fsnotify_mark *mark); -#else +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); +extern void audit_put_chunk(struct audit_chunk *chunk); +extern bool audit_tree_match(struct audit_chunk *chunk, + struct audit_tree *tree); +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); +extern int audit_add_tree_rule(struct audit_krule *rule); +extern int audit_remove_tree_rule(struct audit_krule *rule); +extern void audit_trim_trees(void); +extern int audit_tag_tree(char *old, char *new); +extern const char *audit_tree_path(struct audit_tree *tree); +extern void audit_put_tree(struct audit_tree *tree); +extern void audit_kill_trees(struct audit_context *context); + +extern int audit_signal_info(int sig, struct task_struct *t); +extern void audit_filter_inodes(struct task_struct *tsk, + struct audit_context *ctx); +extern struct list_head *audit_killed_trees(void); +#else /* CONFIG_AUDITSYSCALL */ #define audit_put_watch(w) {} #define audit_get_watch(w) {} #define audit_to_watch(k, p, l, o) (-EINVAL) @@ -301,21 +323,7 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, #define audit_mark_compare(m, i, d) 0 #define audit_exe_compare(t, m) (-EINVAL) #define audit_dupe_exe(n, o) (-EINVAL) -#endif /* CONFIG_AUDITSYSCALL */ -#ifdef CONFIG_AUDITSYSCALL -extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); -extern void audit_put_chunk(struct audit_chunk *chunk); -extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree); -extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); -extern int audit_add_tree_rule(struct audit_krule *rule); -extern int audit_remove_tree_rule(struct audit_krule *rule); -extern void audit_trim_trees(void); -extern int audit_tag_tree(char *old, char *new); -extern const char *audit_tree_path(struct audit_tree *tree); -extern void audit_put_tree(struct audit_tree *tree); -extern void audit_kill_trees(struct audit_context *context); -#else #define audit_remove_tree_rule(rule) BUG() #define audit_add_tree_rule(rule) -EINVAL #define audit_make_tree(rule, str, op) -EINVAL @@ -324,7 +332,10 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, #define audit_tag_tree(old, new) -EINVAL #define audit_tree_path(rule) "" /* never called */ #define audit_kill_trees(context) BUG() -#endif + +#define audit_signal_info(s, t) AUDIT_DISABLED +#define audit_filter_inodes(t, c) AUDIT_DISABLED +#endif /* CONFIG_AUDITSYSCALL */ extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len); @@ -334,14 +345,5 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, extern int audit_filter(int msgtype, unsigned int listtype); -#ifdef CONFIG_AUDITSYSCALL -extern int audit_signal_info(int sig, struct task_struct *t); -extern void audit_filter_inodes(struct task_struct *tsk, struct audit_context *ctx); -extern struct list_head *audit_killed_trees(void); -#else -#define audit_signal_info(s,t) AUDIT_DISABLED -#define audit_filter_inodes(t,c) AUDIT_DISABLED -#endif - extern void audit_ctl_lock(void); extern void audit_ctl_unlock(void); -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs 2019-01-22 22:07 ` [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs Richard Guy Briggs @ 2019-01-25 21:56 ` Paul Moore 0 siblings, 0 replies; 5+ messages in thread From: Paul Moore @ 2019-01-25 21:56 UTC (permalink / raw) To: Richard Guy Briggs Cc: LKML, Linux-Audit Mailing List, Eric Paris, Steve Grubb On Tue, Jan 22, 2019 at 5:08 PM Richard Guy Briggs <rgb@redhat.com> wrote: > > Pull together all the audit syscall watch, mark and tree prototypes and > stubs into the same ifdef. > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > --- > kernel/audit.h | 64 ++++++++++++++++++++++++++++++---------------------------- > 1 file changed, 33 insertions(+), 31 deletions(-) Looks good, merged. > diff --git a/kernel/audit.h b/kernel/audit.h > index 6ffb70575082..22ef49b76daa 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -267,25 +267,47 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, > extern struct tty_struct *audit_get_tty(void); > extern void audit_put_tty(struct tty_struct *tty); > > -/* audit watch functions */ > +/* audit watch/mark/tree functions */ > #ifdef CONFIG_AUDITSYSCALL > extern void audit_put_watch(struct audit_watch *watch); > extern void audit_get_watch(struct audit_watch *watch); > -extern int audit_to_watch(struct audit_krule *krule, char *path, int len, u32 op); > +extern int audit_to_watch(struct audit_krule *krule, char *path, int len, > + u32 op); > extern int audit_add_watch(struct audit_krule *krule, struct list_head **list); > extern void audit_remove_watch_rule(struct audit_krule *krule); > extern char *audit_watch_path(struct audit_watch *watch); > -extern int audit_watch_compare(struct audit_watch *watch, unsigned long ino, dev_t dev); > +extern int audit_watch_compare(struct audit_watch *watch, unsigned long ino, > + dev_t dev); > > -extern struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, char *pathname, int len); > +extern struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, > + char *pathname, int len); > extern char *audit_mark_path(struct audit_fsnotify_mark *mark); > extern void audit_remove_mark(struct audit_fsnotify_mark *audit_mark); > extern void audit_remove_mark_rule(struct audit_krule *krule); > -extern int audit_mark_compare(struct audit_fsnotify_mark *mark, unsigned long ino, dev_t dev); > +extern int audit_mark_compare(struct audit_fsnotify_mark *mark, > + unsigned long ino, dev_t dev); > extern int audit_dupe_exe(struct audit_krule *new, struct audit_krule *old); > -extern int audit_exe_compare(struct task_struct *tsk, struct audit_fsnotify_mark *mark); > +extern int audit_exe_compare(struct task_struct *tsk, > + struct audit_fsnotify_mark *mark); > > -#else > +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); > +extern void audit_put_chunk(struct audit_chunk *chunk); > +extern bool audit_tree_match(struct audit_chunk *chunk, > + struct audit_tree *tree); > +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); > +extern int audit_add_tree_rule(struct audit_krule *rule); > +extern int audit_remove_tree_rule(struct audit_krule *rule); > +extern void audit_trim_trees(void); > +extern int audit_tag_tree(char *old, char *new); > +extern const char *audit_tree_path(struct audit_tree *tree); > +extern void audit_put_tree(struct audit_tree *tree); > +extern void audit_kill_trees(struct audit_context *context); > + > +extern int audit_signal_info(int sig, struct task_struct *t); > +extern void audit_filter_inodes(struct task_struct *tsk, > + struct audit_context *ctx); > +extern struct list_head *audit_killed_trees(void); > +#else /* CONFIG_AUDITSYSCALL */ > #define audit_put_watch(w) {} > #define audit_get_watch(w) {} > #define audit_to_watch(k, p, l, o) (-EINVAL) > @@ -301,21 +323,7 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, > #define audit_mark_compare(m, i, d) 0 > #define audit_exe_compare(t, m) (-EINVAL) > #define audit_dupe_exe(n, o) (-EINVAL) > -#endif /* CONFIG_AUDITSYSCALL */ > > -#ifdef CONFIG_AUDITSYSCALL > -extern struct audit_chunk *audit_tree_lookup(const struct inode *inode); > -extern void audit_put_chunk(struct audit_chunk *chunk); > -extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree); > -extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op); > -extern int audit_add_tree_rule(struct audit_krule *rule); > -extern int audit_remove_tree_rule(struct audit_krule *rule); > -extern void audit_trim_trees(void); > -extern int audit_tag_tree(char *old, char *new); > -extern const char *audit_tree_path(struct audit_tree *tree); > -extern void audit_put_tree(struct audit_tree *tree); > -extern void audit_kill_trees(struct audit_context *context); > -#else > #define audit_remove_tree_rule(rule) BUG() > #define audit_add_tree_rule(rule) -EINVAL > #define audit_make_tree(rule, str, op) -EINVAL > @@ -324,7 +332,10 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, > #define audit_tag_tree(old, new) -EINVAL > #define audit_tree_path(rule) "" /* never called */ > #define audit_kill_trees(context) BUG() > -#endif > + > +#define audit_signal_info(s, t) AUDIT_DISABLED > +#define audit_filter_inodes(t, c) AUDIT_DISABLED > +#endif /* CONFIG_AUDITSYSCALL */ > > extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len); > > @@ -334,14 +345,5 @@ extern void audit_log_d_path_exe(struct audit_buffer *ab, > > extern int audit_filter(int msgtype, unsigned int listtype); > > -#ifdef CONFIG_AUDITSYSCALL > -extern int audit_signal_info(int sig, struct task_struct *t); > -extern void audit_filter_inodes(struct task_struct *tsk, struct audit_context *ctx); > -extern struct list_head *audit_killed_trees(void); > -#else > -#define audit_signal_info(s,t) AUDIT_DISABLED > -#define audit_filter_inodes(t,c) AUDIT_DISABLED > -#endif > - > extern void audit_ctl_lock(void); > extern void audit_ctl_unlock(void); > -- > 1.8.3.1 > -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL 2019-01-22 22:07 [PATCH ghak105 V1 0/2] audit: clean up CONFIG_AUDITSYSCALL Richard Guy Briggs 2019-01-22 22:07 ` [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs Richard Guy Briggs @ 2019-01-22 22:07 ` Richard Guy Briggs 2019-01-25 18:33 ` Richard Guy Briggs 1 sibling, 1 reply; 5+ messages in thread From: Richard Guy Briggs @ 2019-01-22 22:07 UTC (permalink / raw) To: LKML, Linux-Audit Mailing List Cc: Eric Paris, Steve Grubb, Paul Moore, Richard Guy Briggs Remove audit_context from struct task_struct and struct audit_buffer when CONFIG_AUDIT is enabled but CONFIG_AUDITSYSCALL is not. Also, audit_log_name() (and supporting inode and fcaps functions) should have been put back in auditsc.c when soft and hard link logging was normalized since it is only used by syscall auditing. See github issue https://github.com/linux-audit/audit-kernel/issues/105 Signed-off-by: Richard Guy Briggs <rgb@redhat.com> --- include/linux/sched.h | 2 +- kernel/audit.c | 155 +++----------------------------------------------- kernel/audit.h | 9 --- kernel/auditsc.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 157 insertions(+), 157 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index f9788bb122c5..a3a5c657cae9 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -885,8 +885,8 @@ struct task_struct { struct callback_head *task_works; - struct audit_context *audit_context; #ifdef CONFIG_AUDIT + struct audit_context *audit_context; kuid_t loginuid; unsigned int sessionid; #endif diff --git a/kernel/audit.c b/kernel/audit.c index dc375857c59b..79bc49e5162a 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -205,7 +205,9 @@ struct audit_net { * use simultaneously. */ struct audit_buffer { struct sk_buff *skb; /* formatted skb ready to send */ +#ifdef CONFIG_AUDITSYSCALL struct audit_context *ctx; /* NULL or associated context */ +#endif gfp_t gfp_mask; }; @@ -1695,7 +1697,9 @@ static struct audit_buffer *audit_buffer_alloc(struct audit_context *ctx, if (!nlmsg_put(ab->skb, 0, 0, type, 0, 0)) goto err; +#ifdef CONFIG_AUDITSYSCALL ab->ctx = ctx; +#endif ab->gfp_mask = gfp_mask; return ab; @@ -1808,7 +1812,11 @@ struct audit_buffer *audit_log_start(struct audit_context *ctx, gfp_t gfp_mask, return NULL; } +#ifdef CONFIG_AUDITSYSCALL audit_get_stamp(ab->ctx, &t, &serial); +#else + audit_get_stamp(NULL, &t, &serial); +#endif audit_log_format(ab, "audit(%llu.%03lu:%u): ", (unsigned long long)t.tv_sec, t.tv_nsec/1000000, serial); @@ -2066,153 +2074,6 @@ void audit_log_key(struct audit_buffer *ab, char *key) audit_log_format(ab, "(null)"); } -void audit_log_cap(struct audit_buffer *ab, char *prefix, kernel_cap_t *cap) -{ - int i; - - if (cap_isclear(*cap)) { - audit_log_format(ab, " %s=0", prefix); - return; - } - audit_log_format(ab, " %s=", prefix); - CAP_FOR_EACH_U32(i) - audit_log_format(ab, "%08x", cap->cap[CAP_LAST_U32 - i]); -} - -static void audit_log_fcaps(struct audit_buffer *ab, struct audit_names *name) -{ - audit_log_cap(ab, "cap_fp", &name->fcap.permitted); - audit_log_cap(ab, "cap_fi", &name->fcap.inheritable); - audit_log_format(ab, " cap_fe=%d cap_fver=%x", - name->fcap.fE, name->fcap_ver); -} - -static inline int audit_copy_fcaps(struct audit_names *name, - const struct dentry *dentry) -{ - struct cpu_vfs_cap_data caps; - int rc; - - if (!dentry) - return 0; - - rc = get_vfs_caps_from_disk(dentry, &caps); - if (rc) - return rc; - - name->fcap.permitted = caps.permitted; - name->fcap.inheritable = caps.inheritable; - name->fcap.fE = !!(caps.magic_etc & VFS_CAP_FLAGS_EFFECTIVE); - name->fcap_ver = (caps.magic_etc & VFS_CAP_REVISION_MASK) >> - VFS_CAP_REVISION_SHIFT; - - return 0; -} - -/* Copy inode data into an audit_names. */ -void audit_copy_inode(struct audit_names *name, const struct dentry *dentry, - struct inode *inode) -{ - name->ino = inode->i_ino; - name->dev = inode->i_sb->s_dev; - name->mode = inode->i_mode; - name->uid = inode->i_uid; - name->gid = inode->i_gid; - name->rdev = inode->i_rdev; - security_inode_getsecid(inode, &name->osid); - audit_copy_fcaps(name, dentry); -} - -/** - * audit_log_name - produce AUDIT_PATH record from struct audit_names - * @context: audit_context for the task - * @n: audit_names structure with reportable details - * @path: optional path to report instead of audit_names->name - * @record_num: record number to report when handling a list of names - * @call_panic: optional pointer to int that will be updated if secid fails - */ -void audit_log_name(struct audit_context *context, struct audit_names *n, - const struct path *path, int record_num, int *call_panic) -{ - struct audit_buffer *ab; - ab = audit_log_start(context, GFP_KERNEL, AUDIT_PATH); - if (!ab) - return; - - audit_log_format(ab, "item=%d", record_num); - - if (path) - audit_log_d_path(ab, " name=", path); - else if (n->name) { - switch (n->name_len) { - case AUDIT_NAME_FULL: - /* log the full path */ - audit_log_format(ab, " name="); - audit_log_untrustedstring(ab, n->name->name); - break; - case 0: - /* name was specified as a relative path and the - * directory component is the cwd */ - audit_log_d_path(ab, " name=", &context->pwd); - break; - default: - /* log the name's directory component */ - audit_log_format(ab, " name="); - audit_log_n_untrustedstring(ab, n->name->name, - n->name_len); - } - } else - audit_log_format(ab, " name=(null)"); - - if (n->ino != AUDIT_INO_UNSET) - audit_log_format(ab, " inode=%lu" - " dev=%02x:%02x mode=%#ho" - " ouid=%u ogid=%u rdev=%02x:%02x", - n->ino, - MAJOR(n->dev), - MINOR(n->dev), - n->mode, - from_kuid(&init_user_ns, n->uid), - from_kgid(&init_user_ns, n->gid), - MAJOR(n->rdev), - MINOR(n->rdev)); - if (n->osid != 0) { - char *ctx = NULL; - u32 len; - if (security_secid_to_secctx( - n->osid, &ctx, &len)) { - audit_log_format(ab, " osid=%u", n->osid); - if (call_panic) - *call_panic = 2; - } else { - audit_log_format(ab, " obj=%s", ctx); - security_release_secctx(ctx, len); - } - } - - /* log the audit_names record type */ - switch(n->type) { - case AUDIT_TYPE_NORMAL: - audit_log_format(ab, " nametype=NORMAL"); - break; - case AUDIT_TYPE_PARENT: - audit_log_format(ab, " nametype=PARENT"); - break; - case AUDIT_TYPE_CHILD_DELETE: - audit_log_format(ab, " nametype=DELETE"); - break; - case AUDIT_TYPE_CHILD_CREATE: - audit_log_format(ab, " nametype=CREATE"); - break; - default: - audit_log_format(ab, " nametype=UNKNOWN"); - break; - } - - audit_log_fcaps(ab, n); - audit_log_end(ab); -} - int audit_log_task_context(struct audit_buffer *ab) { char *ctx = NULL; diff --git a/kernel/audit.h b/kernel/audit.h index 22ef49b76daa..13210cc52100 100644 --- a/kernel/audit.h +++ b/kernel/audit.h @@ -212,15 +212,6 @@ struct audit_context { extern void audit_log_session_info(struct audit_buffer *ab); -extern void audit_copy_inode(struct audit_names *name, - const struct dentry *dentry, - struct inode *inode); -extern void audit_log_cap(struct audit_buffer *ab, char *prefix, - kernel_cap_t *cap); -extern void audit_log_name(struct audit_context *context, - struct audit_names *n, const struct path *path, - int record_num, int *call_panic); - extern int auditd_test_task(struct task_struct *task); #define AUDIT_INODE_BUCKETS 32 diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 572d247957fb..e8f257fbddaf 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -1136,6 +1136,27 @@ static void audit_log_execve_info(struct audit_context *context, kfree(buf_head); } +void audit_log_cap(struct audit_buffer *ab, char *prefix, kernel_cap_t *cap) +{ + int i; + + if (cap_isclear(*cap)) { + audit_log_format(ab, " %s=0", prefix); + return; + } + audit_log_format(ab, " %s=", prefix); + CAP_FOR_EACH_U32(i) + audit_log_format(ab, "%08x", cap->cap[CAP_LAST_U32 - i]); +} + +static void audit_log_fcaps(struct audit_buffer *ab, struct audit_names *name) +{ + audit_log_cap(ab, "cap_fp", &name->fcap.permitted); + audit_log_cap(ab, "cap_fi", &name->fcap.inheritable); + audit_log_format(ab, " cap_fe=%d cap_fver=%x", + name->fcap.fE, name->fcap_ver); +} + static void show_special(struct audit_context *context, int *call_panic) { struct audit_buffer *ab; @@ -1258,6 +1279,97 @@ static inline int audit_proctitle_rtrim(char *proctitle, int len) return len; } +/* + * audit_log_name - produce AUDIT_PATH record from struct audit_names + * @context: audit_context for the task + * @n: audit_names structure with reportable details + * @path: optional path to report instead of audit_names->name + * @record_num: record number to report when handling a list of names + * @call_panic: optional pointer to int that will be updated if secid fails + */ +static void audit_log_name(struct audit_context *context, struct audit_names *n, + const struct path *path, int record_num, int *call_panic) +{ + struct audit_buffer *ab; + + ab = audit_log_start(context, GFP_KERNEL, AUDIT_PATH); + if (!ab) + return; + + audit_log_format(ab, "item=%d", record_num); + + if (path) + audit_log_d_path(ab, " name=", path); + else if (n->name) { + switch (n->name_len) { + case AUDIT_NAME_FULL: + /* log the full path */ + audit_log_format(ab, " name="); + audit_log_untrustedstring(ab, n->name->name); + break; + case 0: + /* name was specified as a relative path and the + * directory component is the cwd + */ + audit_log_d_path(ab, " name=", &context->pwd); + break; + default: + /* log the name's directory component */ + audit_log_format(ab, " name="); + audit_log_n_untrustedstring(ab, n->name->name, + n->name_len); + } + } else + audit_log_format(ab, " name=(null)"); + + if (n->ino != AUDIT_INO_UNSET) + audit_log_format(ab, " inode=%lu dev=%02x:%02x mode=%#ho ouid=%u ogid=%u rdev=%02x:%02x", + n->ino, + MAJOR(n->dev), + MINOR(n->dev), + n->mode, + from_kuid(&init_user_ns, n->uid), + from_kgid(&init_user_ns, n->gid), + MAJOR(n->rdev), + MINOR(n->rdev)); + if (n->osid != 0) { + char *ctx = NULL; + u32 len; + + if (security_secid_to_secctx( + n->osid, &ctx, &len)) { + audit_log_format(ab, " osid=%u", n->osid); + if (call_panic) + *call_panic = 2; + } else { + audit_log_format(ab, " obj=%s", ctx); + security_release_secctx(ctx, len); + } + } + + /* log the audit_names record type */ + switch (n->type) { + case AUDIT_TYPE_NORMAL: + audit_log_format(ab, " nametype=NORMAL"); + break; + case AUDIT_TYPE_PARENT: + audit_log_format(ab, " nametype=PARENT"); + break; + case AUDIT_TYPE_CHILD_DELETE: + audit_log_format(ab, " nametype=DELETE"); + break; + case AUDIT_TYPE_CHILD_CREATE: + audit_log_format(ab, " nametype=CREATE"); + break; + default: + audit_log_format(ab, " nametype=UNKNOWN"); + break; + } + + audit_log_fcaps(ab, n); + audit_log_end(ab); +} + static void audit_log_proctitle(void) { int res; @@ -1750,6 +1862,42 @@ void __audit_getname(struct filename *name) get_fs_pwd(current->fs, &context->pwd); } +static inline int audit_copy_fcaps(struct audit_names *name, + const struct dentry *dentry) +{ + struct cpu_vfs_cap_data caps; + int rc; + + if (!dentry) + return 0; + + rc = get_vfs_caps_from_disk(dentry, &caps); + if (rc) + return rc; + + name->fcap.permitted = caps.permitted; + name->fcap.inheritable = caps.inheritable; + name->fcap.fE = !!(caps.magic_etc & VFS_CAP_FLAGS_EFFECTIVE); + name->fcap_ver = (caps.magic_etc & VFS_CAP_REVISION_MASK) >> + VFS_CAP_REVISION_SHIFT; + + return 0; +} + +/* Copy inode data into an audit_names. */ +void audit_copy_inode(struct audit_names *name, const struct dentry *dentry, + struct inode *inode) +{ + name->ino = inode->i_ino; + name->dev = inode->i_sb->s_dev; + name->mode = inode->i_mode; + name->uid = inode->i_uid; + name->gid = inode->i_gid; + name->rdev = inode->i_rdev; + security_inode_getsecid(inode, &name->osid); + audit_copy_fcaps(name, dentry); +} + /** * __audit_inode - store the inode and device from a lookup * @name: name being audited -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL 2019-01-22 22:07 ` [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL Richard Guy Briggs @ 2019-01-25 18:33 ` Richard Guy Briggs 0 siblings, 0 replies; 5+ messages in thread From: Richard Guy Briggs @ 2019-01-25 18:33 UTC (permalink / raw) To: LKML, Linux-Audit Mailing List On 2019-01-22 17:07, Richard Guy Briggs wrote: > Remove audit_context from struct task_struct and struct audit_buffer > when CONFIG_AUDIT is enabled but CONFIG_AUDITSYSCALL is not. > > Also, audit_log_name() (and supporting inode and fcaps functions) should > have been put back in auditsc.c when soft and hard link logging was > normalized since it is only used by syscall auditing. > > See github issue https://github.com/linux-audit/audit-kernel/issues/105 > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > --- > include/linux/sched.h | 2 +- > kernel/audit.c | 155 +++----------------------------------------------- > kernel/audit.h | 9 --- > kernel/auditsc.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 157 insertions(+), 157 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index f9788bb122c5..a3a5c657cae9 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -885,8 +885,8 @@ struct task_struct { > > struct callback_head *task_works; > > - struct audit_context *audit_context; > #ifdef CONFIG_AUDIT > + struct audit_context *audit_context; This isn't quite right... audit_context should be wrapped with CONFIG_AUDITSYSCALL. > kuid_t loginuid; > unsigned int sessionid; > #endif > diff --git a/kernel/audit.c b/kernel/audit.c > index dc375857c59b..79bc49e5162a 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -205,7 +205,9 @@ struct audit_net { > * use simultaneously. */ > struct audit_buffer { > struct sk_buff *skb; /* formatted skb ready to send */ > +#ifdef CONFIG_AUDITSYSCALL > struct audit_context *ctx; /* NULL or associated context */ > +#endif > gfp_t gfp_mask; > }; > > @@ -1695,7 +1697,9 @@ static struct audit_buffer *audit_buffer_alloc(struct audit_context *ctx, > if (!nlmsg_put(ab->skb, 0, 0, type, 0, 0)) > goto err; > > +#ifdef CONFIG_AUDITSYSCALL > ab->ctx = ctx; > +#endif > ab->gfp_mask = gfp_mask; > > return ab; > @@ -1808,7 +1812,11 @@ struct audit_buffer *audit_log_start(struct audit_context *ctx, gfp_t gfp_mask, > return NULL; > } > > +#ifdef CONFIG_AUDITSYSCALL > audit_get_stamp(ab->ctx, &t, &serial); > +#else > + audit_get_stamp(NULL, &t, &serial); > +#endif > audit_log_format(ab, "audit(%llu.%03lu:%u): ", > (unsigned long long)t.tv_sec, t.tv_nsec/1000000, serial); > > @@ -2066,153 +2074,6 @@ void audit_log_key(struct audit_buffer *ab, char *key) > audit_log_format(ab, "(null)"); > } > > -void audit_log_cap(struct audit_buffer *ab, char *prefix, kernel_cap_t *cap) > -{ > - int i; > - > - if (cap_isclear(*cap)) { > - audit_log_format(ab, " %s=0", prefix); > - return; > - } > - audit_log_format(ab, " %s=", prefix); > - CAP_FOR_EACH_U32(i) > - audit_log_format(ab, "%08x", cap->cap[CAP_LAST_U32 - i]); > -} > - > -static void audit_log_fcaps(struct audit_buffer *ab, struct audit_names *name) > -{ > - audit_log_cap(ab, "cap_fp", &name->fcap.permitted); > - audit_log_cap(ab, "cap_fi", &name->fcap.inheritable); > - audit_log_format(ab, " cap_fe=%d cap_fver=%x", > - name->fcap.fE, name->fcap_ver); > -} > - > -static inline int audit_copy_fcaps(struct audit_names *name, > - const struct dentry *dentry) > -{ > - struct cpu_vfs_cap_data caps; > - int rc; > - > - if (!dentry) > - return 0; > - > - rc = get_vfs_caps_from_disk(dentry, &caps); > - if (rc) > - return rc; > - > - name->fcap.permitted = caps.permitted; > - name->fcap.inheritable = caps.inheritable; > - name->fcap.fE = !!(caps.magic_etc & VFS_CAP_FLAGS_EFFECTIVE); > - name->fcap_ver = (caps.magic_etc & VFS_CAP_REVISION_MASK) >> > - VFS_CAP_REVISION_SHIFT; > - > - return 0; > -} > - > -/* Copy inode data into an audit_names. */ > -void audit_copy_inode(struct audit_names *name, const struct dentry *dentry, > - struct inode *inode) > -{ > - name->ino = inode->i_ino; > - name->dev = inode->i_sb->s_dev; > - name->mode = inode->i_mode; > - name->uid = inode->i_uid; > - name->gid = inode->i_gid; > - name->rdev = inode->i_rdev; > - security_inode_getsecid(inode, &name->osid); > - audit_copy_fcaps(name, dentry); > -} > - > -/** > - * audit_log_name - produce AUDIT_PATH record from struct audit_names > - * @context: audit_context for the task > - * @n: audit_names structure with reportable details > - * @path: optional path to report instead of audit_names->name > - * @record_num: record number to report when handling a list of names > - * @call_panic: optional pointer to int that will be updated if secid fails > - */ > -void audit_log_name(struct audit_context *context, struct audit_names *n, > - const struct path *path, int record_num, int *call_panic) > -{ > - struct audit_buffer *ab; > - ab = audit_log_start(context, GFP_KERNEL, AUDIT_PATH); > - if (!ab) > - return; > - > - audit_log_format(ab, "item=%d", record_num); > - > - if (path) > - audit_log_d_path(ab, " name=", path); > - else if (n->name) { > - switch (n->name_len) { > - case AUDIT_NAME_FULL: > - /* log the full path */ > - audit_log_format(ab, " name="); > - audit_log_untrustedstring(ab, n->name->name); > - break; > - case 0: > - /* name was specified as a relative path and the > - * directory component is the cwd */ > - audit_log_d_path(ab, " name=", &context->pwd); > - break; > - default: > - /* log the name's directory component */ > - audit_log_format(ab, " name="); > - audit_log_n_untrustedstring(ab, n->name->name, > - n->name_len); > - } > - } else > - audit_log_format(ab, " name=(null)"); > - > - if (n->ino != AUDIT_INO_UNSET) > - audit_log_format(ab, " inode=%lu" > - " dev=%02x:%02x mode=%#ho" > - " ouid=%u ogid=%u rdev=%02x:%02x", > - n->ino, > - MAJOR(n->dev), > - MINOR(n->dev), > - n->mode, > - from_kuid(&init_user_ns, n->uid), > - from_kgid(&init_user_ns, n->gid), > - MAJOR(n->rdev), > - MINOR(n->rdev)); > - if (n->osid != 0) { > - char *ctx = NULL; > - u32 len; > - if (security_secid_to_secctx( > - n->osid, &ctx, &len)) { > - audit_log_format(ab, " osid=%u", n->osid); > - if (call_panic) > - *call_panic = 2; > - } else { > - audit_log_format(ab, " obj=%s", ctx); > - security_release_secctx(ctx, len); > - } > - } > - > - /* log the audit_names record type */ > - switch(n->type) { > - case AUDIT_TYPE_NORMAL: > - audit_log_format(ab, " nametype=NORMAL"); > - break; > - case AUDIT_TYPE_PARENT: > - audit_log_format(ab, " nametype=PARENT"); > - break; > - case AUDIT_TYPE_CHILD_DELETE: > - audit_log_format(ab, " nametype=DELETE"); > - break; > - case AUDIT_TYPE_CHILD_CREATE: > - audit_log_format(ab, " nametype=CREATE"); > - break; > - default: > - audit_log_format(ab, " nametype=UNKNOWN"); > - break; > - } > - > - audit_log_fcaps(ab, n); > - audit_log_end(ab); > -} > - > int audit_log_task_context(struct audit_buffer *ab) > { > char *ctx = NULL; > diff --git a/kernel/audit.h b/kernel/audit.h > index 22ef49b76daa..13210cc52100 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -212,15 +212,6 @@ struct audit_context { > > extern void audit_log_session_info(struct audit_buffer *ab); > > -extern void audit_copy_inode(struct audit_names *name, > - const struct dentry *dentry, > - struct inode *inode); > -extern void audit_log_cap(struct audit_buffer *ab, char *prefix, > - kernel_cap_t *cap); > -extern void audit_log_name(struct audit_context *context, > - struct audit_names *n, const struct path *path, > - int record_num, int *call_panic); > - > extern int auditd_test_task(struct task_struct *task); > > #define AUDIT_INODE_BUCKETS 32 > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 572d247957fb..e8f257fbddaf 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -1136,6 +1136,27 @@ static void audit_log_execve_info(struct audit_context *context, > kfree(buf_head); > } > > +void audit_log_cap(struct audit_buffer *ab, char *prefix, kernel_cap_t *cap) > +{ > + int i; > + > + if (cap_isclear(*cap)) { > + audit_log_format(ab, " %s=0", prefix); > + return; > + } > + audit_log_format(ab, " %s=", prefix); > + CAP_FOR_EACH_U32(i) > + audit_log_format(ab, "%08x", cap->cap[CAP_LAST_U32 - i]); > +} > + > +static void audit_log_fcaps(struct audit_buffer *ab, struct audit_names *name) > +{ > + audit_log_cap(ab, "cap_fp", &name->fcap.permitted); > + audit_log_cap(ab, "cap_fi", &name->fcap.inheritable); > + audit_log_format(ab, " cap_fe=%d cap_fver=%x", > + name->fcap.fE, name->fcap_ver); > +} > + > static void show_special(struct audit_context *context, int *call_panic) > { > struct audit_buffer *ab; > @@ -1258,6 +1279,97 @@ static inline int audit_proctitle_rtrim(char *proctitle, int len) > return len; > } > > +/* > + * audit_log_name - produce AUDIT_PATH record from struct audit_names > + * @context: audit_context for the task > + * @n: audit_names structure with reportable details > + * @path: optional path to report instead of audit_names->name > + * @record_num: record number to report when handling a list of names > + * @call_panic: optional pointer to int that will be updated if secid fails > + */ > +static void audit_log_name(struct audit_context *context, struct audit_names *n, > + const struct path *path, int record_num, int *call_panic) > +{ > + struct audit_buffer *ab; > + > + ab = audit_log_start(context, GFP_KERNEL, AUDIT_PATH); > + if (!ab) > + return; > + > + audit_log_format(ab, "item=%d", record_num); > + > + if (path) > + audit_log_d_path(ab, " name=", path); > + else if (n->name) { > + switch (n->name_len) { > + case AUDIT_NAME_FULL: > + /* log the full path */ > + audit_log_format(ab, " name="); > + audit_log_untrustedstring(ab, n->name->name); > + break; > + case 0: > + /* name was specified as a relative path and the > + * directory component is the cwd > + */ > + audit_log_d_path(ab, " name=", &context->pwd); > + break; > + default: > + /* log the name's directory component */ > + audit_log_format(ab, " name="); > + audit_log_n_untrustedstring(ab, n->name->name, > + n->name_len); > + } > + } else > + audit_log_format(ab, " name=(null)"); > + > + if (n->ino != AUDIT_INO_UNSET) > + audit_log_format(ab, " inode=%lu dev=%02x:%02x mode=%#ho ouid=%u ogid=%u rdev=%02x:%02x", > + n->ino, > + MAJOR(n->dev), > + MINOR(n->dev), > + n->mode, > + from_kuid(&init_user_ns, n->uid), > + from_kgid(&init_user_ns, n->gid), > + MAJOR(n->rdev), > + MINOR(n->rdev)); > + if (n->osid != 0) { > + char *ctx = NULL; > + u32 len; > + > + if (security_secid_to_secctx( > + n->osid, &ctx, &len)) { > + audit_log_format(ab, " osid=%u", n->osid); > + if (call_panic) > + *call_panic = 2; > + } else { > + audit_log_format(ab, " obj=%s", ctx); > + security_release_secctx(ctx, len); > + } > + } > + > + /* log the audit_names record type */ > + switch (n->type) { > + case AUDIT_TYPE_NORMAL: > + audit_log_format(ab, " nametype=NORMAL"); > + break; > + case AUDIT_TYPE_PARENT: > + audit_log_format(ab, " nametype=PARENT"); > + break; > + case AUDIT_TYPE_CHILD_DELETE: > + audit_log_format(ab, " nametype=DELETE"); > + break; > + case AUDIT_TYPE_CHILD_CREATE: > + audit_log_format(ab, " nametype=CREATE"); > + break; > + default: > + audit_log_format(ab, " nametype=UNKNOWN"); > + break; > + } > + > + audit_log_fcaps(ab, n); > + audit_log_end(ab); > +} > + > static void audit_log_proctitle(void) > { > int res; > @@ -1750,6 +1862,42 @@ void __audit_getname(struct filename *name) > get_fs_pwd(current->fs, &context->pwd); > } > > +static inline int audit_copy_fcaps(struct audit_names *name, > + const struct dentry *dentry) > +{ > + struct cpu_vfs_cap_data caps; > + int rc; > + > + if (!dentry) > + return 0; > + > + rc = get_vfs_caps_from_disk(dentry, &caps); > + if (rc) > + return rc; > + > + name->fcap.permitted = caps.permitted; > + name->fcap.inheritable = caps.inheritable; > + name->fcap.fE = !!(caps.magic_etc & VFS_CAP_FLAGS_EFFECTIVE); > + name->fcap_ver = (caps.magic_etc & VFS_CAP_REVISION_MASK) >> > + VFS_CAP_REVISION_SHIFT; > + > + return 0; > +} > + > +/* Copy inode data into an audit_names. */ > +void audit_copy_inode(struct audit_names *name, const struct dentry *dentry, > + struct inode *inode) > +{ > + name->ino = inode->i_ino; > + name->dev = inode->i_sb->s_dev; > + name->mode = inode->i_mode; > + name->uid = inode->i_uid; > + name->gid = inode->i_gid; > + name->rdev = inode->i_rdev; > + security_inode_getsecid(inode, &name->osid); > + audit_copy_fcaps(name, dentry); > +} > + > /** > * __audit_inode - store the inode and device from a lookup > * @name: name being audited > -- > 1.8.3.1 > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-25 21:56 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-01-22 22:07 [PATCH ghak105 V1 0/2] audit: clean up CONFIG_AUDITSYSCALL Richard Guy Briggs 2019-01-22 22:07 ` [PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs Richard Guy Briggs 2019-01-25 21:56 ` Paul Moore 2019-01-22 22:07 ` [PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL Richard Guy Briggs 2019-01-25 18:33 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox