From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC106C282DA for ; Wed, 17 Apr 2019 19:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3350206BA for ; Wed, 17 Apr 2019 19:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731194AbfDQT7a (ORCPT ); Wed, 17 Apr 2019 15:59:30 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:48478 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726751AbfDQT7a (ORCPT ); Wed, 17 Apr 2019 15:59:30 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from asmaa@mellanox.com) with ESMTPS (AES256-SHA encrypted); 17 Apr 2019 22:59:25 +0300 Received: from farm-1.mtbu.labs.mlnx (farm-1.mtbu.labs.mlnx [10.15.2.31]) by mtbu-labmailer.labs.mlnx (8.14.4/8.14.4) with ESMTP id x3HJxN7B011512; Wed, 17 Apr 2019 15:59:23 -0400 Received: (from asmaa@localhost) by farm-1.mtbu.labs.mlnx (8.14.7/8.13.8/Submit) id x3HJxMSX030983; Wed, 17 Apr 2019 15:59:22 -0400 From: Asmaa Mnebhi To: minyard@acm.org Cc: Asmaa Mnebhi , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: [PATCH v2 0/1] *** Add support for IPMB driver *** Date: Wed, 17 Apr 2019 15:59:18 -0400 Message-Id: X-Mailer: git-send-email 2.1.2 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you for your feedback Corey. I have addressed your inlined comments. I understand your suggestion for making this an I2C driver. I can certainly make those changes once we hear back from the i2c mailing list. My only concern is that the ipmb_write is responsible for sending the response via SMBus, so it needs the total length of the message. So we need to document that this driver requires that the user program (it is attached) passes the msg length as the first byte in the message. Asmaa Mnebhi (1): Add support for IPMB driver drivers/char/ipmi/Kconfig | 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi/ipmb_dev_int.c | 407 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 416 insertions(+) create mode 100644 drivers/char/ipmi/ipmb_dev_int.c -- 2.1.2