From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/4] tracing: Improve error messages for histogram sorting
Date: Fri, 28 Jun 2019 12:40:19 -0500 [thread overview]
Message-ID: <cover.1561743018.git.zanussi@kernel.org> (raw)
This is v2 of the histogram sorting error message patchset. The code
is the same as v1 - this version only adds new Fixes:, Reviewed-by:,
and Reported-by: tags.
Text from original post:
Hi,
These patches add some improvements for histogram sorting, addressing
some shortcomings pointed out by Masami.
In order to address the specific problem pointed out by Masami, as
well as add additional related error messages, the first patch
does some simplification of assignment parsing.
The second patch actually adds the new error messages.
The fourth patch adds a new testcase for hist trigger parsing, similar
to the same kind of tests for kprobes and uprobes. Additional tests
covering all possible hist trigger errors should/will be added here in
the future.
The third patch just adds a missing hist: prefix to the error log so
that the testcases work properly, and which should have been there
anyway.
Thanks,
Tom
The following changes since commit a124692b698b00026a58d89831ceda2331b2e1d0:
ftrace: Enable trampoline when rec count returns back to one (2019-05-25 23:04:43 -0400)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace-hist-sort-err-msgs-v2
Tom Zanussi (4):
tracing: Simplify assignment parsing for hist triggers
tracing: Add hist trigger error messages for sort specification
tracing: Add 'hist:' to hist trigger error log error string
tracing: Add new testcases for hist trigger parsing errors
kernel/trace/trace_events_hist.c | 94 +++++++++++-----------
.../test.d/trigger/trigger-hist-syntax-errors.tc | 32 ++++++++
2 files changed, 78 insertions(+), 48 deletions(-)
create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc
--
2.14.1
next reply other threads:[~2019-06-28 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 17:40 Tom Zanussi [this message]
2019-06-28 17:40 ` [PATCH v2 1/4] tracing: Simplify assignment parsing for hist triggers Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 2/4] tracing: Add hist trigger error messages for sort specification Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 3/4] tracing: Add 'hist:' to hist trigger error log error string Tom Zanussi
2019-06-28 17:40 ` [PATCH v2 4/4] tracing: Add new testcases for hist trigger parsing errors Tom Zanussi
2020-01-29 14:22 ` Steven Rostedt
2020-01-29 14:44 ` Tom Zanussi
2020-01-29 14:53 ` Steven Rostedt
2020-01-29 15:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1561743018.git.zanussi@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox