* [PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c
@ 2019-07-24 14:36 Asmaa Mnebhi
2019-07-24 17:45 ` Asmaa Mnebhi
0 siblings, 1 reply; 5+ messages in thread
From: Asmaa Mnebhi @ 2019-07-24 14:36 UTC (permalink / raw)
To: minyard; +Cc: Asmaa Mnebhi, linux-kernel
ret at line 112 of ipmb_dev_int.c is uninitialized which
results in a warning during build regressions.
Asmaa Mnebhi (1):
Fix uninitialized variable in ipmb_dev_int.c
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.1.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c
2019-07-24 14:36 [PATCH v1 0/1] " Asmaa Mnebhi
@ 2019-07-24 17:45 ` Asmaa Mnebhi
0 siblings, 0 replies; 5+ messages in thread
From: Asmaa Mnebhi @ 2019-07-24 17:45 UTC (permalink / raw)
To: minyard; +Cc: Asmaa Mnebhi, linux-kernel
ret at line 112 of ipmb_dev_int.c is uninitialized which
results in a warning during build regressions.
This warning was reported during regression testing led by Geert
Uytterhoeven for v5.3-rc1.
Asmaa Mnebhi (1):
Fix uninitialized variable in ipmb_dev_int.c
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.1.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c
@ 2019-07-24 19:32 Asmaa Mnebhi
2019-07-24 19:32 ` [PATCH v1 1/1] " Asmaa Mnebhi
0 siblings, 1 reply; 5+ messages in thread
From: Asmaa Mnebhi @ 2019-07-24 19:32 UTC (permalink / raw)
To: minyard; +Cc: Asmaa Mnebhi, linux-kernel
ret at line 112 of ipmb_dev_int.c is uninitialized which
results in a warning during build regressions.
This warning was reported during regression/improvement
testing led by Geert Uytterhoeven for v5.3-rc1.
Asmaa Mnebhi (1):
Fix uninitialized variable in ipmb_dev_int.c
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.1.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c
2019-07-24 19:32 [PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c Asmaa Mnebhi
@ 2019-07-24 19:32 ` Asmaa Mnebhi
2019-07-24 20:53 ` Corey Minyard
0 siblings, 1 reply; 5+ messages in thread
From: Asmaa Mnebhi @ 2019-07-24 19:32 UTC (permalink / raw)
To: minyard; +Cc: Asmaa Mnebhi, linux-kernel, asmaa
ret at line 112 of ipmb_dev_int.c is uninitialized which
results in a warning during build regressions.
This warning was found by build regression/improvement
testing for v5.3-rc1.
Reported-by: build regression/improvement testing for v5.3-rc1.
Fixes: 51bd6f291583 ("Add support for IPMB driver")
Signed-off-by: Asmaa Mnebhi <Asmaa@mellanox.com>
---
drivers/char/ipmi/ipmb_dev_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
index 5720433..285e0b8 100644
--- a/drivers/char/ipmi/ipmb_dev_int.c
+++ b/drivers/char/ipmi/ipmb_dev_int.c
@@ -76,7 +76,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
struct ipmb_request_elem *queue_elem;
struct ipmb_msg msg;
- ssize_t ret;
+ ssize_t ret = 0;
memset(&msg, 0, sizeof(msg));
--
2.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c
2019-07-24 19:32 ` [PATCH v1 1/1] " Asmaa Mnebhi
@ 2019-07-24 20:53 ` Corey Minyard
0 siblings, 0 replies; 5+ messages in thread
From: Corey Minyard @ 2019-07-24 20:53 UTC (permalink / raw)
To: Asmaa Mnebhi; +Cc: linux-kernel
On Wed, Jul 24, 2019 at 03:32:57PM -0400, Asmaa Mnebhi wrote:
> ret at line 112 of ipmb_dev_int.c is uninitialized which
> results in a warning during build regressions.
> This warning was found by build regression/improvement
> testing for v5.3-rc1.
Applied, thanks for sticking with it :).
-corey
>
> Reported-by: build regression/improvement testing for v5.3-rc1.
> Fixes: 51bd6f291583 ("Add support for IPMB driver")
> Signed-off-by: Asmaa Mnebhi <Asmaa@mellanox.com>
> ---
> drivers/char/ipmi/ipmb_dev_int.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
> index 5720433..285e0b8 100644
> --- a/drivers/char/ipmi/ipmb_dev_int.c
> +++ b/drivers/char/ipmi/ipmb_dev_int.c
> @@ -76,7 +76,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
> struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
> struct ipmb_request_elem *queue_elem;
> struct ipmb_msg msg;
> - ssize_t ret;
> + ssize_t ret = 0;
>
> memset(&msg, 0, sizeof(msg));
>
> --
> 2.1.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-24 20:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 19:32 [PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c Asmaa Mnebhi
2019-07-24 19:32 ` [PATCH v1 1/1] " Asmaa Mnebhi
2019-07-24 20:53 ` Corey Minyard
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 14:36 [PATCH v1 0/1] " Asmaa Mnebhi
2019-07-24 17:45 ` Asmaa Mnebhi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox