From: Ben Luo <luoben@linux.alibaba.com>
To: tglx@linutronix.de, alex.williamson@redhat.com
Cc: linux-kernel@vger.kernel.org, tao.ma@linux.alibaba.com,
gerry@linux.alibaba.com, nanhai.zou@linux.alibaba.com,
linyunsheng@huawei.com
Subject: [PATCH v4 0/3] genirq/vfio: Introduce irq_update_devid() and optimize VFIO irq ops
Date: Thu, 22 Aug 2019 23:34:40 +0800 [thread overview]
Message-ID: <cover.1566486156.git.luoben@linux.alibaba.com> (raw)
Currently, VFIO takes uses a free-then-request-irq way to do interrupt
affinity setting and masking/unmasking for a VM (with device passthru
via VFIO). Sometimes only change the cookie data of irqaction or even
change nothing. The free-then-request-irq not only adds more latency,
but also increases the risk of losing interrupt, which may lead to a
VM hung forever in waiting for IO completion
This patchset solved the issue by:
Patch 2 introduces irq_update_devid() to only update dev_id of irqaction
Patch 3 make use of this function and optimize irq operations in VFIO
changes from v3:
- rename the new function to irq_update_devid()
- amend commit messages and code comments
- use disbale_irq()/enable_irq() to avoid a twist for threaded interrupt
- add more comments to vfio-pci code
changes from v2:
- reformat to avoid quoted string split across lines and etc.
changes from v1:
- add Patch 1 to enhance error recovery etc. in free irq per tglx's comments
- enhance error recovery code and debugging info in irq_update_devid
- use __must_check in external referencing of this function
- use EXPORT_SYMBOL_GPL for irq_update_devid
- reformat code of patch 3 for better readability
Ben Luo (3):
genirq: enhance error recovery code in free irq
genirq: introduce irq_update_devid()
vfio/pci: make use of irq_update_devid and optimize irq ops
drivers/vfio/pci/vfio_pci_intrs.c | 112 +++++++++++++++++++++++++-------------
include/linux/interrupt.h | 3 +
kernel/irq/manage.c | 105 +++++++++++++++++++++++++++++++----
3 files changed, 170 insertions(+), 50 deletions(-)
--
1.8.3.1
next reply other threads:[~2019-08-22 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 15:34 Ben Luo [this message]
2019-08-22 15:34 ` [PATCH v4 1/3] genirq: enhance error recovery code in free irq Ben Luo
2019-08-22 15:34 ` [PATCH v4 2/3] genirq: introduce irq_update_devid() Ben Luo
2019-08-22 15:34 ` [PATCH v4 3/3] vfio/pci: make use of irq_update_devid and optimize irq ops Ben Luo
2019-08-27 20:33 ` Alex Williamson
2019-08-28 10:08 ` Ben Luo
2019-08-28 17:23 ` Alex Williamson
2019-08-29 5:40 ` Ben Luo
2019-08-29 13:48 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1566486156.git.luoben@linux.alibaba.com \
--to=luoben@linux.alibaba.com \
--cc=alex.williamson@redhat.com \
--cc=gerry@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=nanhai.zou@linux.alibaba.com \
--cc=tao.ma@linux.alibaba.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox