public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Luo <luoben@linux.alibaba.com>
To: tglx@linutronix.de, alex.williamson@redhat.com
Cc: linux-kernel@vger.kernel.org, tao.ma@linux.alibaba.com,
	gerry@linux.alibaba.com, nanhai.zou@linux.alibaba.com
Subject: [PATCH v6 0/3] genirq/vfio: Introduce irq_update_devid() and optimize VFIO irq ops
Date: Mon,  2 Sep 2019 12:01:49 +0800	[thread overview]
Message-ID: <cover.1567394624.git.luoben@linux.alibaba.com> (raw)

Currently, VFIO takes a free-then-request-irq way to do interrupt
affinity setting and masking/unmasking for a VM with device passthru
via VFIO. Sometimes it only changes the cookie data of irqaction or even
changes nothing. The free-then-request-irq not only adds more latency,
but also increases the risk of losing interrupt, which may lead to a
VM hang forever in waiting for IO completion

This patchset solved the issue by:
Patch 2 introduces irq_update_devid() to only update dev_id of irqaction
Patch 3 make use of this function and optimize irq operations in VFIO

changes from v5:
 - Patch 3: remove an error log to avoid potential DDoS attacking
 _ Patch 3: fix typo in comment

changes from v4:
 - Patch 3: follow the previous behavior to disable interrupt on error path
 - Patch 3: do irqbypass registration before update or free the interrupt
 - Patch 3: add more comments

changes from v3:
 - Patch 2: rename the new function to irq_update_devid()
 - Patch 2: use disbale_irq() to avoid a twist for threaded interrupt
 - ALL: amend commit messages and code comments

changes from v2:
 - reformat to avoid quoted string split across lines and etc.

changes from v1:
 - add Patch 1 to enhance error recovery etc. in free irq per tglx's comments
 - enhance error recovery code and debugging info in irq_update_devid
 - use __must_check in external referencing of this function
 - use EXPORT_SYMBOL_GPL for irq_update_devid
 - reformat code of patch 3 for better readability

Ben Luo (3):
  genirq: enhance error recovery code in free irq
  genirq: introduce irq_update_devid()
  vfio/pci: make use of irq_update_devid() and optimize irq ops

 drivers/vfio/pci/vfio_pci_intrs.c | 118 ++++++++++++++++++++++++++------------
 include/linux/interrupt.h         |   3 +
 kernel/irq/manage.c               | 105 +++++++++++++++++++++++++++++----
 3 files changed, 177 insertions(+), 49 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2019-09-02  4:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02  4:01 Ben Luo [this message]
2019-09-02  4:01 ` [PATCH v6 1/3] genirq: enhance error recovery code in free irq Ben Luo
2019-09-02  4:01 ` [PATCH v6 2/3] genirq: introduce irq_update_devid() Ben Luo
2019-09-02  4:01 ` [PATCH v6 3/3] vfio/pci: make use of irq_update_devid() and optimize irq ops Ben Luo
2019-09-10  6:30 ` [PATCH v6 0/3] genirq/vfio: Introduce irq_update_devid() and optimize VFIO " Ben Luo
2019-09-13 17:44   ` Alex Williamson
2019-09-16 14:16     ` Thomas Gleixner
2019-12-05 10:12       ` Ben Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1567394624.git.luoben@linux.alibaba.com \
    --to=luoben@linux.alibaba.com \
    --cc=alex.williamson@redhat.com \
    --cc=gerry@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nanhai.zou@linux.alibaba.com \
    --cc=tao.ma@linux.alibaba.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox