Re: [RFC PATCH 0/5] Add TEE interface support to AMD Secure Processor driver

Thomas, Rijo-john
2019-10-24T11:21:26Z

Hello Tom,

On 23/10/19 9:57 PM, Lendacky, Thomas wrote:
> On 10/23/19 6:27 AM, Thomas, Rijo-john wrote:
>> The goal of this patch series is to introduce TEE (Trusted Execution
>> Environment) interface support to AMD Secure Processor driver. The
>> TEE is a secure area of a processor which ensures that sensitive data
>> is stored, processed and protected in an isolated and trusted
>> environment. The Platform Security Processor (PSP) is a dedicated
>> processor which provides TEE to enable HW platform security. It offers
>> protection against software attacks generated in Rich Operating System
>> (Rich OS) such as Linux running on x86.
>>
>> Based on the platform feature support, the PSP is capable of supporting
>> either SEV (Secure Encrypted Virtualization) and/or TEE. The first three
>> patches in this series is about moving SEV specific functions and data
>> structures from PSP device driver file to a dedicated SEV interface
>> driver file. The last two patches add TEE interface support to AMD
>> Secure Processor driver. This TEE interface will be used by AMD-TEE
>> driver to submit command buffers for processing in PSP Trusted Execution
>> Environment.
>
> There are some outstanding patches that have been submitted that modify
> some of the same files you are modifying, so you'll need to rebase after
> those patches are applied. Also, one patch was applied through the KVM
> tree, not sure how to handle that.
>
> For reference, here are the submitted patches:
>
> https://lore.kernel.org/kvm/6108561e392460ade67f7f70d9bfa9f56a925d0a.1570137447.git.thomas.lendacky@amd.com/
> https://lore.kernel.org/linux-crypto/20191017223459.64281-1-Ashish.Kalra@amd.com/
> https://lore.kernel.org/linux-crypto/157166548259.28287.18118802909801681546.stgit@taos/

I will take a note of this. I will rebase once these patches are merged.

Thanks,
Rijo

>
> Thanks,
> Tom
>
>>
>> Rijo Thomas (5):
>> crypto: ccp - rename psp-dev files to sev-dev
>> crypto: ccp - create a generic psp-dev file
>> crypto: ccp - move SEV vdata to a dedicated data structure
>> crypto: ccp - add TEE support for Raven Ridge
>> crypto: ccp - provide in-kernel API to submit TEE commands
>>
>> drivers/crypto/ccp/Makefile | 4 +-
>> drivers/crypto/ccp/psp-dev.c | 983 +++------------------------------------
>> drivers/crypto/ccp/psp-dev.h | 50 +-
>> drivers/crypto/ccp/sev-dev.c | 1041 ++++++++++++++++++++++++++++++++++++++++++
>> drivers/crypto/ccp/sev-dev.h | 62 +++
>> drivers/crypto/ccp/sp-dev.h | 17 +-
>> drivers/crypto/ccp/sp-pci.c | 43 +-
>> drivers/crypto/ccp/tee-dev.c | 363 +++++++++++++++
>> drivers/crypto/ccp/tee-dev.h | 109 +++++
>> include/linux/psp-tee.h | 72 +++
>> 10 files changed, 1796 insertions(+), 948 deletions(-)
>> create mode 100644 drivers/crypto/ccp/sev-dev.c
>> create mode 100644 drivers/crypto/ccp/sev-dev.h
>> create mode 100644 drivers/crypto/ccp/tee-dev.c
>> create mode 100644 drivers/crypto/ccp/tee-dev.h
>> create mode 100644 include/linux/psp-tee.h
>>