Re: [RFC PATCH 1/5] crypto: ccp - rename psp-dev files to sev-dev

Thomas, Rijo-john
2019-10-24T11:19:46Z

Hello Ard,

On 23/10/19 5:18 PM, Ard Biesheuvel wrote:
> Hello Thomas,
>
> On Wed, 23 Oct 2019 at 13:27, Thomas, Rijo-john
> <Rijo-john.Thomas@amd.com> wrote:
>>
>> This is a preliminary patch for creating a generic PSP device driver
>> file, which will have support for both SEV and TEE (Trusted Execution
>> Environment) interface.
>>
>> This patch does not introduce any new functionality, but simply renames
>> psp-dev.c and psp-dev.h files to sev-dev.c and sev-dev.h files
>> respectively.
>>
>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
>> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
>
> This is not the correct way to credit a co-author.
>
> You are sending the patch, so your signoff should come last.
>
> If Devaraj is a co-author of this work, you should add the following
> lines *before* your signoff
>
> Co-authored-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
> Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
>
> If Devaraj is the sole author of this work, and you are just sending
> it out, you should set the authorship on the patch to Devaraj (so it
> will be From: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>)
>

Okay, in my next patch revision I shall correct this.
Devaraj is the co-author.

So, the lines would like like:

Co-authored-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
Signed-off-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

>> ---
>> drivers/crypto/ccp/Makefile | 2 +-
>> drivers/crypto/ccp/psp-dev.c | 1087 ------------------------------------------
>> drivers/crypto/ccp/psp-dev.h | 66 ---
>> drivers/crypto/ccp/sev-dev.c | 1087 ++++++++++++++++++++++++++++++++++++++++++
>> drivers/crypto/ccp/sev-dev.h | 66 +++
>> drivers/crypto/ccp/sp-pci.c | 2 +-
>> 6 files changed, 1155 insertions(+), 1155 deletions(-)
>> delete mode 100644 drivers/crypto/ccp/psp-dev.c
>> delete mode 100644 drivers/crypto/ccp/psp-dev.h
>> create mode 100644 drivers/crypto/ccp/sev-dev.c
>> create mode 100644 drivers/crypto/ccp/sev-dev.h
>>
>
> Please regenerate the patch so that the rename is reflected in the diffstat.
>

Okay, I will regenerate the patch with proper diffstat.

Thanks,
Rijo