Re: [PATCH 5/9] staging: rtl8723bs: Add necessary braces

Greg KH
2019-11-12T23:04:16Z

On Tue, Nov 12, 2019 at 11:54:32AM -0500, Javier F. Arias wrote:
> This patchset adds braces when they should be used on all arms of
> the statement.
> Issue found by Checkpatch.
>
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 31 +++++++++++++++--------
> 1 file changed, 20 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index fdb585ff5925..42bd5d8362fa 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -370,8 +370,9 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame *
> /* Other fragments are protected by previous fragment. */
> /* So we only need to check the length of first fragment. */
> if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N || padapter->registrypriv.wifi_spec) {
> - if (sz > padapter->registrypriv.rts_thresh)
> + if (sz > padapter->registrypriv.rts_thresh) {
> pattrib->vcs_mode = RTS_CTS;
> + }
> else {

The } should be on the same line as the "else {"

thanks,

greg k-h