Re: [Outreachy kernel] Re: [PATCH 7/9] staging: rtl8723bs: Fix incorrect type in argument warnings

Javier F. Arias
2019-11-12T23:00:20Z

On Tue, Nov 12, 2019 at 09:11:42AM -0800, Joe Perches wrote:
> On Tue, 2019-11-12 at 11:55 -0500, Javier F. Arias wrote:
> > Fix incorrect type in declarations to solve the 'incorrect
> > type in argument 3' warnings in the rtw_get_ie function calls.
> > Issue found by Sparse.
> []
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> []
> > @@ -83,7 +83,7 @@ static char *translate_scan(struct adapter *padapter,
> > {
> > struct iw_event iwe;
> > u16 cap;
> > - u32 ht_ielen = 0;
> > + sint ht_ielen = 0;
>
> more likely the rtw_get_ie function should used u32
> and not sint.

Thanks for your feedback. I'll update the patchset and CC you as
I can't send anything else to the Outreachy maillist.

> one day a sed of 's/\bsint\b/int/g' would be good too.

I'll probably do this on a couple of involved files.

>
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/c243860eeabf9406d166deb6204a69255c51867d.camel%40perches.com.