From: Andrey Konovalov <andreyknvl@google.com>
To: Dmitry Vyukov <dvyukov@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH v1 0/3] kcov: collect coverage from usb soft interrupts
Date: Wed, 26 Feb 2020 19:48:06 +0100 [thread overview]
Message-ID: <cover.1582742673.git.andreyknvl@google.com> (raw)
This patchset extends kcov to allow collecting coverage from soft
interrupts and then uses the new functionality to collect coverage from
USB code.
This has allowed to find at least one new HID bug [1], which was recently
fixed by Alan [2].
[1] https://syzkaller.appspot.com/bug?extid=09ef48aa58261464b621
[2] https://patchwork.kernel.org/patch/11283319/
This patchset has been pushed to the public Linux kernel Gerrit instance:
https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2225
Changes RFC -> v1:
- Don't support hardirq or nmi, only softirq, to avoid issues with nested
interrupts.
- Combined multiple per-cpu variables into one.
- Used plain accesses and kcov_start/stop() instead of xchg()'s.
- Simplified handling of per-cpu variables.
- Avoid disabling interrupts for the whole kcov_remote_start/stop()
region.
- Avoid overwriting t->kcov_sequence when saving/restoring state.
- Move kcov_remote_start/stop_usb() annotations into
__usb_hcd_giveback_urb() to cover all urb complete() callbacks at once.
- Drop unneeded Dummy HCD changes.
- Split out a patch that removed debug messages.
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Andrey Konovalov (3):
kcov: cleanup debug messages
kcov: collect coverage from interrupts
usb: core: kcov: collect coverage from usb complete callback
Documentation/dev-tools/kcov.rst | 17 +--
drivers/usb/core/hcd.c | 3 +
include/linux/sched.h | 3 +
kernel/kcov.c | 187 ++++++++++++++++++++-----------
lib/Kconfig.debug | 9 ++
5 files changed, 147 insertions(+), 72 deletions(-)
--
2.25.1.481.gfbce0eb801-goog
next reply other threads:[~2020-02-26 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 18:48 Andrey Konovalov [this message]
2020-02-26 18:48 ` [PATCH v1 1/3] kcov: cleanup debug messages Andrey Konovalov
2020-02-26 18:48 ` [PATCH v1 2/3] kcov: collect coverage from interrupts Andrey Konovalov
2020-02-26 18:48 ` [PATCH v1 3/3] usb: core: kcov: collect coverage from usb complete callback Andrey Konovalov
2020-02-27 1:41 ` [PATCH v1 0/3] kcov: collect coverage from usb soft interrupts Andrew Morton
2020-02-27 15:44 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1582742673.git.andreyknvl@google.com \
--to=andreyknvl@google.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox