From: Michal Kubecek <mkubecek@suse.cz>
To: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v2 00/15] ethtool netlink interface, part 3
Date: Thu, 12 Mar 2020 21:07:33 +0100 (CET) [thread overview]
Message-ID: <cover.1584043144.git.mkubecek@suse.cz> (raw)
Implementation of more netlink request types:
- netdev features (ethtool -k/-K, patches 3-6)
- private flags (--show-priv-flags / --set-priv-flags, patches 7-9)
- ring sizes (ethtool -g/-G, patches 10-12)
- channel counts (ethtool -l/-L, patches 13-15)
Patch 1 is a style cleanup suggested in part 2 review and patch 2 updates
the mapping between netdev features and legacy ioctl requests (which are
still used by ethtool for backward compatibility).
Changes in v2:
- fix netdev reference leaks in error path of ethnl_set_rings() and
ethnl_set_channels() (found by Jakub Kicinski)
- use __set_bit() rather than set_bit() (suggested by David Miller)
- in replies to RINGS_GET and CHANNELS_GET requests, omit ring and
channel types not supported by driver/device (suggested by Jakub
Kicinski)
- more descriptive message size calculations in rings_reply_size() and
channels_reply_size() (suggested by Jakub Kicinski)
- coding style cleanup (suggested by Jakub Kicinski)
Michal Kubecek (15):
ethtool: rename ethnl_parse_header() to ethnl_parse_header_dev_get()
ethtool: update mapping of features to legacy ioctl requests
ethtool: provide netdev features with FEATURES_GET request
ethtool: add ethnl_parse_bitset() helper
ethtool: set netdev features with FEATURES_SET request
ethtool: add FEATURES_NTF notification
ethtool: provide private flags with PRIVFLAGS_GET request
ethtool: set device private flags with PRIVFLAGS_SET request
ethtool: add PRIVFLAGS_NTF notification
ethtool: provide ring sizes with RINGS_GET request
ethtool: set device ring sizes with RINGS_SET request
ethtool: add RINGS_NTF notification
ethtool: provide channel counts with CHANNELS_GET request
ethtool: set device channel counts with CHANNELS_SET request
ethtool: add CHANNELS_NTF notification
Documentation/networking/ethtool-netlink.rst | 272 +++++++++++++++--
include/uapi/linux/ethtool_netlink.h | 82 +++++
net/ethtool/Makefile | 3 +-
net/ethtool/bitset.c | 94 ++++++
net/ethtool/bitset.h | 4 +
net/ethtool/channels.c | 227 ++++++++++++++
net/ethtool/common.c | 31 ++
net/ethtool/common.h | 3 +
net/ethtool/debug.c | 6 +-
net/ethtool/features.c | 304 +++++++++++++++++++
net/ethtool/ioctl.c | 52 +---
net/ethtool/linkinfo.c | 6 +-
net/ethtool/linkmodes.c | 6 +-
net/ethtool/netlink.c | 99 +++++-
net/ethtool/netlink.h | 15 +-
net/ethtool/privflags.c | 209 +++++++++++++
net/ethtool/rings.c | 200 ++++++++++++
net/ethtool/wol.c | 5 +-
18 files changed, 1538 insertions(+), 80 deletions(-)
create mode 100644 net/ethtool/channels.c
create mode 100644 net/ethtool/features.c
create mode 100644 net/ethtool/privflags.c
create mode 100644 net/ethtool/rings.c
--
2.25.1
next reply other threads:[~2020-03-12 20:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 20:07 Michal Kubecek [this message]
2020-03-12 20:07 ` [PATCH net-next v2 01/15] ethtool: rename ethnl_parse_header() to ethnl_parse_header_dev_get() Michal Kubecek
2020-03-12 20:07 ` [PATCH net-next v2 02/15] ethtool: update mapping of features to legacy ioctl requests Michal Kubecek
2020-03-12 20:07 ` [PATCH net-next v2 03/15] ethtool: provide netdev features with FEATURES_GET request Michal Kubecek
2020-03-12 20:07 ` [PATCH net-next v2 04/15] ethtool: add ethnl_parse_bitset() helper Michal Kubecek
2020-03-12 20:07 ` [PATCH net-next v2 05/15] ethtool: set netdev features with FEATURES_SET request Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 06/15] ethtool: add FEATURES_NTF notification Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 07/15] ethtool: provide private flags with PRIVFLAGS_GET request Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 08/15] ethtool: set device private flags with PRIVFLAGS_SET request Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 09/15] ethtool: add PRIVFLAGS_NTF notification Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 10/15] ethtool: provide ring sizes with RINGS_GET request Michal Kubecek
2020-03-12 20:48 ` Jakub Kicinski
2020-03-12 20:08 ` [PATCH net-next v2 11/15] ethtool: set device ring sizes with RINGS_SET request Michal Kubecek
2020-03-12 20:50 ` Jakub Kicinski
2020-03-12 20:08 ` [PATCH net-next v2 12/15] ethtool: add RINGS_NTF notification Michal Kubecek
2020-03-12 20:08 ` [PATCH net-next v2 13/15] ethtool: provide channel counts with CHANNELS_GET request Michal Kubecek
2020-03-12 20:51 ` Jakub Kicinski
2020-03-12 20:08 ` [PATCH net-next v2 14/15] ethtool: set device channel counts with CHANNELS_SET request Michal Kubecek
2020-03-12 20:54 ` Jakub Kicinski
2020-03-12 20:08 ` [PATCH net-next v2 15/15] ethtool: add CHANNELS_NTF notification Michal Kubecek
2020-03-12 22:32 ` [PATCH net-next v2 00/15] ethtool netlink interface, part 3 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1584043144.git.mkubecek@suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox