Re: [PATCH 2/2] mfd: Introduce QTI I2C PMIC controller

kbuild test robot
2020-05-01T13:49:42Z

[-- Attachment #1: Type: text/plain, Size: 3270 bytes --]

Hi Guru,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on v5.7-rc3 next-20200501]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Guru-Das-Srinagesh/Introduce-QTI-I2C-PMIC-controller/20200428-175503
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/mfd/qcom-i2c-pmic.c: In function 'i2c_pmic_suspend_noirq':
>> drivers/mfd/qcom-i2c-pmic.c:703:10: error: expected ';' before '}' token
703 | return 0
| ^
| ;
704 | }
| ~

vim +703 drivers/mfd/qcom-i2c-pmic.c

653
654 static int i2c_pmic_resume(struct device *dev)
655 {
656 struct i2c_pmic *chip = dev_get_drvdata(dev);
657 struct i2c_pmic_periph *periph;
658 int rc = 0, i;
659
660 for (i = 0; i < chip->num_periphs; i++) {
661 periph = &chip->periph[i];
662
663 rc = regmap_write(chip->regmap,
664 periph->addr | INT_EN_CLR_OFFSET, 0xFF);
665 if (rc < 0) {
666 pr_err("Couldn't clear 0x%04x irqs rc=%d\n",
667 periph->addr, rc);
668 continue;
669 }
670
671 rc = regmap_write(chip->regmap,
672 periph->addr | INT_EN_SET_OFFSET,
673 periph->synced[IRQ_EN_SET]);
674 if (rc < 0)
675 pr_err("Couldn't restore 0x%04x synced irqs 0x%02x rc=%d\n",
676 periph->addr, periph->synced[IRQ_EN_SET], rc);
677 }
678
679 mutex_lock(&chip->irq_complete);
680 chip->resume_completed = true;
681 if (chip->irq_waiting) {
682 mutex_unlock(&chip->irq_complete);
683 /* irq was pending, call the handler */
684 i2c_pmic_irq_handler(chip->summary_irq, chip);
685 enable_irq(chip->summary_irq);
686 } else {
687 mutex_unlock(&chip->irq_complete);
688 }
689
690 return rc;
691 }
692 #else
693 static int i2c_pmic_suspend(struct device *dev)
694 {
695 return 0;
696 }
697 static int i2c_pmic_resume(struct device *dev)
698 {
699 return 0;
700 }
701 static int i2c_pmic_suspend_noirq(struct device *dev)
702 {
> 703 return 0
704 }
705 #endif
706 static const struct dev_pm_ops i2c_pmic_pm_ops = {
707 .suspend = i2c_pmic_suspend,
708 .suspend_noirq = i2c_pmic_suspend_noirq,
709 .resume = i2c_pmic_resume,
710 };
711

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56845 bytes --]