Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA

Reinette Chatre
2020-05-16T18:03:27Z

Hi Babu,

On 5/14/2020 12:04 PM, Babu Moger wrote:
>
>
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Wednesday, May 6, 2020 6:50 PM
>> To: tglx@linutronix.de; fenghua.yu@intel.com; bp@alien8.de;
>> tony.luck@intel.com
>> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com; mingo@redhat.com;
>> Moger, Babu <Babu.Moger@amd.com>; hpa@zytor.com; x86@kernel.org;
>> linux-kernel@vger.kernel.org; Reinette Chatre <reinette.chatre@intel.com>
>> Subject: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA
>>
>> From: Fenghua Yu <fenghua.yu@intel.com>
>>

...

>> static int rdt_thread_throttle_mode_show(struct kernfs_open_file *of,
>> struct seq_file *seq, void *v)
>> {
>> unsigned int throttle_mode = 0;
>>
>> + if (boot_cpu_has(X86_FEATURE_PER_THREAD_MBA)) {
>> + seq_puts(seq, "per-thread\n");
>> +
> You probably don't need an extra line here.
>

This area looks slightly different after moving to a resource property
but unnecessary extra lines will be removed.

Thank you very much

Reinette