Re: [PATCH 1/2] fs: avoid fdput() after failed fdget() in ksys_sync_file_range()

Al Viro
2020-05-08T00:05:21Z

On Thu, May 07, 2020 at 05:57:09PM -0600, Shuah Khan wrote:
> Fix ksys_sync_file_range() to avoid fdput() after a failed fdget().
> fdput() doesn't do fput() on this file since FDPUT_FPUT isn't set
> in fd.flags. Fix it anyway since failed fdget() doesn't require
> a fdput().
>
> This was introdcued in a commit to add sync_file_range() helper.

Er... What's the point microoptimizing the slow path here?