From: Siddharth Chandrasekaran <csiddharth@vmware.com>
To: gregkh@linuxfoundation.org
Cc: srostedt@vmware.com, linux-kernel@vger.kernel.org,
stable@kernel.org, srivatsab@vmware.com, csiddharth@vmware.com,
siddharth@embedjournal.com, dchinner@redhat.com,
darrick.wong@oracle.com
Subject: [PATCH] Backport security fixe to 4.9 and 4.4 stable trees
Date: Fri, 15 May 2020 02:25:20 +0530 [thread overview]
Message-ID: <cover.1589486724.git.csiddharth@vmware.com> (raw)
Due to lack of proper validation that cached inodes are free during allocation,
causes a crash (refer to CVE-2018-13093 for more details). To address this
issue, I'm backporting upstream commit [1] to 4.4 and 4.9 stable trees
(a backport of [1] to 4.14 already exists).
Also, commit [1] references another commit [2] which added checks only to
xfs_iget_cache_miss(). In this patch, those checks have been moved into a
dedicated checker method and both xfs_iget_cache_miss() and
xfs_iget_cache_hit() are made to call that method. This code reorg in commit
[1], makes commit [2] redundant in the history of the 4.9 and 4.4 stable
trees. So commit [2] is not being backported.
-- Sid
[1]: afca6c5b2595f ("xfs: validate cached inodes are free when allocated")
[2]: ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
[v4.9]
Dave Chinner (1):
xfs: More robust inode extent count validation
fs/xfs/libxfs/xfs_format.h | 3 ++
fs/xfs/libxfs/xfs_inode_buf.c | 112 ++++++++++++++++++++++++++++++++++++++++--
2 files changed, 112 insertions(+), 3 deletions(-)
[v.4.4]
Dave Chinner (1):
xfs: validate cached inodes are free when allocated
fs/xfs/xfs_icache.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 50 insertions(+), 7 deletions(-)
--
2.7.4
next reply other threads:[~2020-05-14 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 20:55 Siddharth Chandrasekaran [this message]
2020-05-14 20:55 ` [PATCH v4.9] xfs: More robust inode extent count validation Siddharth Chandrasekaran
2020-05-14 20:55 ` [PATCH v4.4] xfs: validate cached inodes are free when allocated Siddharth Chandrasekaran
2020-05-15 12:49 ` [PATCH] Backport security fixe to 4.9 and 4.4 stable trees Siddharth Chandrasekaran
2020-05-15 12:57 ` Greg KH
2020-05-15 13:29 ` Siddharth Chandrasekaran
2020-05-15 13:40 ` Greg KH
2020-05-15 13:52 ` Steven Rostedt
2020-05-15 14:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1589486724.git.csiddharth@vmware.com \
--to=csiddharth@vmware.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siddharth@embedjournal.com \
--cc=srivatsab@vmware.com \
--cc=srostedt@vmware.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox