Re: [PATCH 3/3] platform/x86: dell-wmi: add keys to bios_to_linux_keycode

Pali Rohár
2020-06-08T20:48:30Z

On Monday 08 June 2020 15:46:44 Mario.Limonciello@dell.com wrote:
> I would actually question if there is value to lines in dell-wmi.c like this:
>
> pr_info("Unknown WMI event type 0x%x\n", (int)buffer_entry[1]);
>
> and
>
> pr_info("Unknown key with type 0x%04x and code 0x%04x pressed\n", type, code);
>
> In both of those cases the information doesn't actually help the user, by default it's
> ignored by the driver anyway. It just notifies the user it's something the driver doesn't
> comprehend. I would think these are better suited to downgrade to debug. And if
> a key combination isn't doing something expected the user can use dyndbg to turn it
> back on and can be debugged what should be populated or "explicitly" ignored.

My motivation for these messages was to provide information to user that
kernel received event, but was not able to process it as it do not
understand it.

It could help in situation when user press special key and nothing is
delivered to userspace. But he could see that something happened in log.

Similar message is also printed by PS/2 keyboard driver atkbd.c:

case ATKBD_KEY_UNKNOWN:
dev_warn(&serio->dev,
"Unknown key %s (%s set %d, code %#x on %s).\n",
atkbd->release ? "released" : "pressed",
atkbd->translated ? "translated" : "raw",
atkbd->set, code, serio->phys);
dev_warn(&serio->dev,
"Use 'setkeycodes %s%02x <keycode>' to make it known.\n",
code & 0x80 ? "e0" : "", code & 0x7f);
input_sync(dev);
break;