* [PATCH v2 0/2] Fix some build warnings when W=1 @ 2020-07-16 13:05 Zong Li 2020-07-16 13:05 ` [PATCH v2 1/2] riscv: Fix build warning for mm/init Zong Li 2020-07-16 13:05 ` [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr Zong Li 0 siblings, 2 replies; 6+ messages in thread From: Zong Li @ 2020-07-16 13:05 UTC (permalink / raw) To: palmer, paul.walmsley, linux-riscv, linux-kernel; +Cc: Zong Li These patches fix some build warnings when W=1, the most of warnings are missing prototype as follows: arch/riscv/mm/init.c:520:13: warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:130:5: warning: no previous prototype for 'set_memory_ro' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:136:5: warning: no previous prototype for 'set_memory_rw' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:142:5: warning: no previous prototype for 'set_memory_x' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:147:5: warning: no previous prototype for 'set_memory_nx' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:152:5: warning: no previous prototype for 'set_direct_map_invalid_noflush' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:169:5: warning: no previous prototype for 'set_direct_map_default_noflush' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:97:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] Changed in v2: - Modify the patch description Zong Li (2): riscv: Fix build warning for mm/init riscv: Fix build warning for mm/pageattr arch/riscv/mm/init.c | 2 +- arch/riscv/mm/pageattr.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.27.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] riscv: Fix build warning for mm/init 2020-07-16 13:05 [PATCH v2 0/2] Fix some build warnings when W=1 Zong Li @ 2020-07-16 13:05 ` Zong Li 2020-07-16 13:07 ` Pekka Enberg 2020-07-16 13:19 ` Anup Patel 2020-07-16 13:05 ` [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr Zong Li 1 sibling, 2 replies; 6+ messages in thread From: Zong Li @ 2020-07-16 13:05 UTC (permalink / raw) To: palmer, paul.walmsley, linux-riscv, linux-kernel; +Cc: Zong Li Add static keyword for resource_init, this function is only used in this object file. The warning message as follow (with W=1 build): arch/riscv/mm/init.c:520:13: warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] Signed-off-by: Zong Li <zong.li@sifive.com> --- arch/riscv/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 92002952c621..66f5952f39c0 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -517,7 +517,7 @@ void mark_rodata_ro(void) } #endif -void __init resource_init(void) +static void __init resource_init(void) { struct memblock_region *region; -- 2.27.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] riscv: Fix build warning for mm/init 2020-07-16 13:05 ` [PATCH v2 1/2] riscv: Fix build warning for mm/init Zong Li @ 2020-07-16 13:07 ` Pekka Enberg 2020-07-16 13:19 ` Anup Patel 1 sibling, 0 replies; 6+ messages in thread From: Pekka Enberg @ 2020-07-16 13:07 UTC (permalink / raw) To: Zong Li; +Cc: Palmer Dabbelt, Paul Walmsley, linux-riscv, LKML On Thu, Jul 16, 2020 at 4:06 PM Zong Li <zong.li@sifive.com> wrote: > > Add static keyword for resource_init, this function is only used in this > object file. > > The warning message as follow (with W=1 build): > > arch/riscv/mm/init.c:520:13: > warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] > > Signed-off-by: Zong Li <zong.li@sifive.com> Reviewed-by: Pekka Enberg <penberg@kernel.org> - Pekka ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] riscv: Fix build warning for mm/init 2020-07-16 13:05 ` [PATCH v2 1/2] riscv: Fix build warning for mm/init Zong Li 2020-07-16 13:07 ` Pekka Enberg @ 2020-07-16 13:19 ` Anup Patel 1 sibling, 0 replies; 6+ messages in thread From: Anup Patel @ 2020-07-16 13:19 UTC (permalink / raw) To: Zong Li Cc: Palmer Dabbelt, Paul Walmsley, linux-riscv, linux-kernel@vger.kernel.org List On Thu, Jul 16, 2020 at 6:35 PM Zong Li <zong.li@sifive.com> wrote: > > Add static keyword for resource_init, this function is only used in this > object file. > > The warning message as follow (with W=1 build): > > arch/riscv/mm/init.c:520:13: > warning: no previous prototype for 'resource_init' [-Wmissing-prototypes] > > Signed-off-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 92002952c621..66f5952f39c0 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -517,7 +517,7 @@ void mark_rodata_ro(void) > } > #endif > > -void __init resource_init(void) > +static void __init resource_init(void) > { > struct memblock_region *region; > > -- > 2.27.0 > Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr 2020-07-16 13:05 [PATCH v2 0/2] Fix some build warnings when W=1 Zong Li 2020-07-16 13:05 ` [PATCH v2 1/2] riscv: Fix build warning for mm/init Zong Li @ 2020-07-16 13:05 ` Zong Li 2020-07-16 13:20 ` Anup Patel 1 sibling, 1 reply; 6+ messages in thread From: Zong Li @ 2020-07-16 13:05 UTC (permalink / raw) To: palmer, paul.walmsley, linux-riscv, linux-kernel; +Cc: Zong Li, Pekka Enberg Add header for missing prototype. Also, static keyword should be at beginning of declaration. The warning messages as follows (with W=1 build): arch/riscv/mm/pageattr.c:130:5: warning: no previous prototype for 'set_memory_ro' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:136:5: warning: no previous prototype for 'set_memory_rw' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:142:5: warning: no previous prototype for 'set_memory_x' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:147:5: warning: no previous prototype for 'set_memory_nx' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:152:5: warning: no previous prototype for 'set_direct_map_invalid_noflush' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:169:5: warning: no previous prototype for 'set_direct_map_default_noflush' [-Wmissing-prototypes] arch/riscv/mm/pageattr.c:97:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Zong Li <zong.li@sifive.com> Reviewed-by: Pekka Enberg <penberg@kernel.org> --- arch/riscv/mm/pageattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c index 289a9a5ea5b5..19fecb362d81 100644 --- a/arch/riscv/mm/pageattr.c +++ b/arch/riscv/mm/pageattr.c @@ -7,6 +7,7 @@ #include <linux/pgtable.h> #include <asm/tlbflush.h> #include <asm/bitops.h> +#include <asm/set_memory.h> struct pageattr_masks { pgprot_t set_mask; @@ -94,7 +95,7 @@ static int pageattr_pte_hole(unsigned long addr, unsigned long next, return 0; } -const static struct mm_walk_ops pageattr_ops = { +static const struct mm_walk_ops pageattr_ops = { .pgd_entry = pageattr_pgd_entry, .p4d_entry = pageattr_p4d_entry, .pud_entry = pageattr_pud_entry, -- 2.27.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr 2020-07-16 13:05 ` [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr Zong Li @ 2020-07-16 13:20 ` Anup Patel 0 siblings, 0 replies; 6+ messages in thread From: Anup Patel @ 2020-07-16 13:20 UTC (permalink / raw) To: Zong Li Cc: Palmer Dabbelt, Paul Walmsley, linux-riscv, linux-kernel@vger.kernel.org List, Pekka Enberg On Thu, Jul 16, 2020 at 6:36 PM Zong Li <zong.li@sifive.com> wrote: > > Add header for missing prototype. Also, static keyword should be at > beginning of declaration. > > The warning messages as follows (with W=1 build): > > arch/riscv/mm/pageattr.c:130:5: > warning: no previous prototype for 'set_memory_ro' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:136:5: > warning: no previous prototype for 'set_memory_rw' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:142:5: > warning: no previous prototype for 'set_memory_x' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:147:5: > warning: no previous prototype for 'set_memory_nx' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:152:5: > warning: no previous prototype for 'set_direct_map_invalid_noflush' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:169:5: > warning: no previous prototype for 'set_direct_map_default_noflush' [-Wmissing-prototypes] > > arch/riscv/mm/pageattr.c:97:1: > warning: 'static' is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Zong Li <zong.li@sifive.com> > Reviewed-by: Pekka Enberg <penberg@kernel.org> > --- > arch/riscv/mm/pageattr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c > index 289a9a5ea5b5..19fecb362d81 100644 > --- a/arch/riscv/mm/pageattr.c > +++ b/arch/riscv/mm/pageattr.c > @@ -7,6 +7,7 @@ > #include <linux/pgtable.h> > #include <asm/tlbflush.h> > #include <asm/bitops.h> > +#include <asm/set_memory.h> > > struct pageattr_masks { > pgprot_t set_mask; > @@ -94,7 +95,7 @@ static int pageattr_pte_hole(unsigned long addr, unsigned long next, > return 0; > } > > -const static struct mm_walk_ops pageattr_ops = { > +static const struct mm_walk_ops pageattr_ops = { > .pgd_entry = pageattr_pgd_entry, > .p4d_entry = pageattr_p4d_entry, > .pud_entry = pageattr_pud_entry, > -- > 2.27.0 > Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-16 13:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-16 13:05 [PATCH v2 0/2] Fix some build warnings when W=1 Zong Li 2020-07-16 13:05 ` [PATCH v2 1/2] riscv: Fix build warning for mm/init Zong Li 2020-07-16 13:07 ` Pekka Enberg 2020-07-16 13:19 ` Anup Patel 2020-07-16 13:05 ` [PATCH v2 2/2] riscv: Fix build warning for mm/pageattr Zong Li 2020-07-16 13:20 ` Anup Patel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox