Re: [PATCH 3/3] staging: androind: Convert BUG() to WARN()

Tomer Samara
2020-08-16T17:43:53Z

On Sun, Aug 16, 2020 at 10:34:50AM -0700, Randy Dunlap wrote:
> On 8/16/20 10:22 AM, Tomer Samara wrote:
> > replace BUG() with WARN() at ion_sytem_heap.c, this
> > fix the following checkpatch issue:
> > Avoid crashing the kernel - try using WARN_ON &
> > recovery code ratherthan BUG() or BUG_ON().
> >
> > Signed-off-by: Tomer Samara <tomersamara98@gmail.com>
> > ---
> > drivers/staging/android/ion/ion_system_heap.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> > index eac0632ab4e8..37065a59ca69 100644
> > --- a/drivers/staging/android/ion/ion_system_heap.c
> > +++ b/drivers/staging/android/ion/ion_system_heap.c
> > @@ -30,7 +30,8 @@ static int order_to_index(unsigned int order)
> > for (i = 0; i < NUM_ORDERS; i++)
> > if (order == orders[i])
> > return i;
> > - BUG();
> > +
> > + WARN(1, "%s: Did not found index to order %d", __FUNCTION__, order);
> > return -1;
> > }
>
> Hi,
> Did you look at what happens when order_to_index() returns -1
> to its callers?
>
>
> Also: fix spelling in Subjects: android and BUG/BUG_ON
>
> --
> ~Randy
>

Hi,
yes I've made a patch for that too but it seems I forgot to
include him in the patch set.
I will send new version for this patch set soon.

Thanks