Re: [PATCH v2 0/8] Some improvements for blk throttle

Jens Axboe
2020-10-08T14:02:12Z

On 10/7/20 9:52 PM, Baolin Wang wrote:
> Hi,
>
> This patch set did some improvements for blk throttle, please
> help to review. Thanks.
>
> Changes from v1:
> - Add another 4 new patches in this patch set.
>
> Baolin Wang (8):
> blk-throttle: Remove a meaningless parameter for
> throtl_downgrade_state()
> blk-throttle: Avoid getting the current time if tg->last_finish_time
> is 0
> blk-throttle: Avoid tracking latency if low limit is invalid
> blk-throttle: Fix IO hang for a corner case
> blk-throttle: Move the list operation after list validation
> blk-throttle: Move service tree validation out of the
> throtl_rb_first()
> blk-throttle: Open code __throtl_de/enqueue_tg()
> blk-throttle: Re-use the throtl_set_slice_end()
>
> block/blk-throttle.c | 69 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 35 insertions(+), 34 deletions(-)

LGTM, applied, thanks.

--
Jens Axboe