From: Chunguang Xu <brookxu.cn@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com
Cc: harshadshirwadkar@gmail.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH v3 0/3] make jbd2 debug switch per device
Date: Wed, 27 Jan 2021 16:22:03 +0800 [thread overview]
Message-ID: <cover.1611733806.git.brookxu@tencent.com> (raw)
On a multi-disk machine, because jbd2 debugging switch is global, this
confuses the logs of multiple disks. It is not easy to distinguish the
logs of each disk and the amount of generated logs is very large. Maybe
a separate debugging switch for each disk would be better, so that we
can easily distinguish the logs of a certain disk.
We can enable jbd2 debugging of a device in the following ways:
echo X > /proc/fs/jbd2/sdX/jbd2_debug
But there is a small disadvantage here. Because the debugging switch is
placed in the journal_t object, the log before the object is initialized
will be lost. However, usually this will not have much impact on
debugging.
Chunguang Xu (3):
jbd2: make jdb2_debug module parameter per device
jbd2: update the arguments of jbd_debug()
ext4: update the arguments of jbd_debug()
fs/ext4/balloc.c | 2 +-
fs/ext4/ext4_jbd2.c | 4 +-
fs/ext4/fast_commit.c | 60 ++++++++++++++-----------
fs/ext4/indirect.c | 4 +-
fs/ext4/inode.c | 3 +-
fs/ext4/namei.c | 10 ++---
fs/ext4/super.c | 15 ++++---
fs/jbd2/checkpoint.c | 6 +--
fs/jbd2/commit.c | 32 ++++++-------
fs/jbd2/journal.c | 101 ++++++++++++++++++++++++++++++++----------
fs/jbd2/recovery.c | 32 ++++++-------
fs/jbd2/revoke.c | 8 ++--
fs/jbd2/transaction.c | 30 ++++++-------
include/linux/jbd2.h | 41 ++++++++++-------
14 files changed, 209 insertions(+), 139 deletions(-)
--
2.30.0
next reply other threads:[~2021-01-27 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 8:22 Chunguang Xu [this message]
2021-01-27 8:22 ` [RFC PATCH v3 1/3] jbd2: make jdb2_debug module parameter per device Chunguang Xu
2021-01-27 8:22 ` [RFC PATCH v3 2/3] jbd2: update the arguments of jbd_debug() Chunguang Xu
2021-01-27 8:22 ` [RFC PATCH v3 3/3] ext4: " Chunguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1611733806.git.brookxu@tencent.com \
--to=brookxu.cn@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox