From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810FEC433EF for ; Mon, 4 Oct 2021 13:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 573E260FC3 for ; Mon, 4 Oct 2021 13:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235462AbhJDN7S (ORCPT ); Mon, 4 Oct 2021 09:59:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238817AbhJDN6N (ORCPT ); Mon, 4 Oct 2021 09:58:13 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00C60C06136A for ; Mon, 4 Oct 2021 06:53:18 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id x4so11146220pln.5 for ; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=HD1FAaEtufc7ayGdPFagvKFo4lY+o6I6/nQOa+nVkJHZWF4gn1Zd86f56QDiJmRERT cJ7/qKo40ISZ9l6pLFbm7BG+GvlqxekUCZucWtRLoGIZL0sAmMTGgGxEbo+89QGomMqk F06R/fZFslZqdzjDhsuFd6DM9UJxmwRmegojJHXlFwjzshrhgKufUcrnmWtk8oQOyKyV 48P036+d1eYmnHMqEMXCm084uNEGSg9txbxUXWiU69JjBsacmUsrPGih+ky85b/2QB3r lLSD1qhYF77rBR/NWuUVA4marCG9VaWVfBOoI9Rnw4dd1xAyB9uJHKQU04cUUSzm0j6p Zhuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=QEHON0D16NOtj7ensvhXDzaDAgXu65RHuXm2ylfQ/LFCHDSkmt7lxkYv9tTiWOfDfK /Ae2mcbazucq3xEt7wldDJ33qKtlQ27zw/U52borL0pHdFqiXYRn3xqiQ727/GOr9G61 MlS/YuabSZQU9b8TUY+gx4RG9DuoMFodH6q5aO55bUVjmY++qNAzUokofdTrZI5QP3vC jwTkblwBbYEf9IPHnSCgFGrT6V5IzHKIjiNx3ud1B6KQgMATc3BbWGQicybDFHU/fnmn JDHsHFbRuVDsA/RiGj7jWJi07RmIsG3iVZnrebBezaMxH9aHt9xWw+HqUQc5VAA7tS8a ATCQ== X-Gm-Message-State: AOAM530mrBZ0m+nWhn0RjQPGiFyq6pe3SH0SD8JMu9JJDsA7ODDjbiG7 19HuBZXh47URFIlOZSa+ZKI= X-Google-Smtp-Source: ABdhPJyN7WK8TDIV07lY6Vw3BSCzWsRh8SxCdZyrqPzER9GZiXV7WlUHrJTVeRbnHqxrI3lD1Qshqw== X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr31119195pji.241.1633355597382; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id k17sm12209548pfu.82.2021.10.04.06.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 06:53:16 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:22:35 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Naveen Naidu (8): [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH 2/8] PCI: Cleanup struct aer_err_info [PATCH 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E9AC433F5 for ; Mon, 4 Oct 2021 14:08:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97BA061251 for ; Mon, 4 Oct 2021 14:08:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233604AbhJDOKD (ORCPT ); Mon, 4 Oct 2021 10:10:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbhJDOKB (ORCPT ); Mon, 4 Oct 2021 10:10:01 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D35C061745; Mon, 4 Oct 2021 07:08:12 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id 133so16664130pgb.1; Mon, 04 Oct 2021 07:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=o/QK+MjgwS+aEQuPx4irPsbCaHMW6sfXp8BaqM12h1M93plmbNOTRFIEVh1NBvMkEB ZUI/rsaRIpecJgpTBkNdVhjXxkwcmFdasoMV5ExX4poVBKt+rT6b3AXqoH8YrS1V9Cma yTLd30q8/soHf0V8eO5srZz85E1ywxMMQjSiHSXBQmm4FwKQnXqmnLibeVWcAbhZsPoG g7rBm1DWVZe9gEnb4fnGCjTY7cLC1uB+fjbWcPtPfaxV99JFomRFEybhCoXr3oNyDkpZ +zue++onjHrY646/5Vrk8fAzNswt0qpQPvj0GEqZcPrHvgmnxDwplbLQUFeXbAVc1+Wk 8g0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=V0CbbIIoy7DHD3t1qapP9Cv+MPDzyzoP9m9AwYSCD+Ny6cc9AoaAXn+mbsRyh0z8Ry 5U0tEubGXfCAE2Gbp68wPCFnxNPz1OgNisOSl2rbeqJ0XpDocWRFAbzpeyKzwMGBFGAR j3Iq7aSm26GOc9i/fcw1o/RTy/00uM/CGBrweVEIbQpzQoChRBlBGSFVJ915lhN7Cx7v Gb5P6CFm5Rkhw4N4Nfmsp//LPhQjrkqlExb0S3RwmBWF4uJBnhySDVxeg/8KZo4qY/VG IRc1BCwM+1XWWMc3eYjEGKLVMt2IbFh6SNn3bthQhLamXFBnYDjZDPswEvhxuTrHODIA wP8A== X-Gm-Message-State: AOAM531jGsIW0Mcj+EalpIq0s8aXaKs+/LQIsYTYmf1WVnHarCSLean9 FjiFrDrm1rJ+mUmed6qxUP8= X-Google-Smtp-Source: ABdhPJxdmeh3wBzsACdJJKEbMJ6nFPRgGudEiYPsvM9XJ9KsMd2LE/efWBCTvow/NjbvzslzV8Q/lg== X-Received: by 2002:a63:63c5:: with SMTP id x188mr5138080pgb.391.1633356491815; Mon, 04 Oct 2021 07:08:11 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id p2sm15274135pgd.84.2021.10.04.07.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:08:11 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: [PATCH v2 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:36:26 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20211004140626.aa-OCgblBo049SqAlgcfAQUPOceVrQEz41GMkYrk44U@z> This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v2: Apologies for the mistake, I forgot to cc the linux-pci mailing list. Resent the email with cc to linux-pci. Naveen Naidu (8): [PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v2 2/8] PCI: Cleanup struct aer_err_info [PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1