Re: [PATCH net-next v3 1/5] devlink: Reduce struct devlink exposure

Steven Rostedt
2021-10-07T19:58:09Z

On Thu, 7 Oct 2021 09:55:15 +0300
Leon Romanovsky <leon@kernel.org> wrote:

> +void *devlink_priv(struct devlink *devlink)
> +{
> + BUG_ON(!devlink);

Do we really want to bring down the kernel in this case?

Can't we just have:

if (WARN_ON(!devlink))
return NULL;
?

Same for the below as well.

-- Steve

> + return &devlink->priv;
> +}
> +EXPORT_SYMBOL_GPL(devlink_priv);
> +
> +struct devlink *priv_to_devlink(void *priv)
> +{
> + BUG_ON(!priv);
> + return container_of(priv, struct devlink, priv);
> +}
> +EXPORT_SYMBOL_GPL(priv_to_devlink);
> +
> +struct device *devlink_to_dev(const struct devlink *devlink)
> +{
> + return devlink->dev;
> +}
> +EXPORT_SYMBOL_GPL(devlink_to_dev);
> +