From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] clk: fix the need of booking clk_ignore_unused=true on embedded devs
Date: Thu, 7 Oct 2021 14:06:53 +0200 [thread overview]
Message-ID: <cover.1633607765.git.mchehab+huawei@kernel.org> (raw)
Currently, the only way to boot a Kernel with drivers built as modules on embedded
devices like HiKey 970 is to pass clk_ignore_unused=true as a modprobe parameter.
There are two separate issues:
1. the clk's core calls clk_disable_unused() too early. By the time this
function is called, only the builtin drivers were already probed/initialized.
Drivers built as modules will only be probed afterwards.
This cause a race condition and boot instability, as the clk core will try
to disable clocks while the drivers built as modules are still being
probed and initialized.
I suspect that the same problem used to happen at the regulator's core,
as there's a code that waits for 30 seconds before disabling unused
regulators;
2. there are some gate clocks defined at HiKey 970 that should always be on,
as otherwise the system will hang, or the filesystem I/O will stop.
Ps.:
I submitted already 3 or 4 versions of patches for HiKey 970 clock, but
they're all unreliable, due to the race conditions at the clk core due to (1).
Patch 1 solves the issue with the clk core.
Patch 2 solves the HiKey 970 specific issues.
Mauro Carvalho Chehab (2):
clk: wait for extra time before disabling unused clocks
clk: clk-hi3670: mark some clocks as CLK_IS_CRITICAL
drivers/clk/clk.c | 51 +++++++++++++++++++-----------
drivers/clk/hisilicon/clk-hi3670.c | 24 +++++++-------
2 files changed, 44 insertions(+), 31 deletions(-)
--
2.31.1
next reply other threads:[~2021-10-07 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:06 Mauro Carvalho Chehab [this message]
2021-10-07 12:06 ` [PATCH 1/2] clk: wait for extra time before disabling unused clocks Mauro Carvalho Chehab
2021-10-07 12:06 ` [PATCH 2/2] clk: clk-hi3670: mark some clocks as CLK_IS_CRITICAL Mauro Carvalho Chehab
2021-10-11 6:17 ` [PATCH 0/2] clk: fix the need of booking clk_ignore_unused=true on embedded devs Manivannan Sadhasivam
2021-10-14 6:44 ` Mauro Carvalho Chehab
2021-10-27 7:21 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1633607765.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mani@kernel.org \
--cc=mauro.chehab@huawei.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox