Re: [PATCH 1/7] staging: vt6655: Introduce `idx` temporary variable

Dan Carpenter
2021-11-04T12:06:29Z

On Thu, Oct 28, 2021 at 11:35:31AM +0100, Karolina Drobnik wrote:
> Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset.
> This change helps in shortening the lines in `rf.c` that
> are deemed too long by checkpatch.pl.
>

No, this just makes the code harder to read. Don't introduce a local
variable which only holds a global constant. Variables should be
variable and constants should be constants. No one wants to have to
look up things for no reason.

regards,
dan carpenter