From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: [PATCH 0/7] Address issues preventing camorama to work with atomisp
Date: Thu, 4 Nov 2021 12:05:49 +0000 [thread overview]
Message-ID: <cover.1636026959.git.mchehab+huawei@kernel.org> (raw)
This patch series address some issues at atomisp that are preventing camorama
to work with atomisp driver.
After this series, I can use camorama just like on any other device. The frame
rate is slow (~7fps), though. Not sure if this is due to some sensor limitation or
because of some other issue.
Anyway this is a start :-)
Some notes:
1. Patch 1 fixes an issue at ov2680 logic. It probably needs to be reflected at the
other supported sensors;
2. MMAP is not working. So, it requires a newer version of camorama that has
support for USERPTR.
3. There's nothing special on Camorama for atomisp, except that it has support
for USERPTR.
4. Camorama currently doesn't allow changing the resolution of the camera.
That's because of several things:
a. The driver has a scaler, supporting resolutions from 32x16 to 1600x1200
on Asus T101HA.
b. The atomisp driver doesn't implement ENUM_FRAMEINTERVALS;
c. camorama is not prepared for cameras with scalers on it. It just lets one to
select the resolutions enumerated by ENUM_FRAMEINTERVALS.
Mauro Carvalho Chehab (7):
media: atomisp-ov2680: use v4l2_find_nearest_size()
media: atomisp: move a debug printf to a better place
media: atomisp: fix VIDIOC_S_FMT logic
media: atomisp: fix enum_fmt logic
media: atomisp: move atomisp_g_fmt_cap()
media: atomisp: fix try_fmt logic
media: atomisp: fix g_fmt logic
.../media/atomisp/i2c/atomisp-ov2680.c | 127 +++-----------
drivers/staging/media/atomisp/i2c/ov2680.h | 3 +-
.../staging/media/atomisp/pci/atomisp_cmd.c | 59 +++++--
.../staging/media/atomisp/pci/atomisp_ioctl.c | 157 ++++++++++--------
4 files changed, 162 insertions(+), 184 deletions(-)
--
2.31.1
next reply other threads:[~2021-11-04 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 12:05 Mauro Carvalho Chehab [this message]
2021-11-04 12:05 ` [PATCH 1/7] media: atomisp-ov2680: use v4l2_find_nearest_size() Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 2/7] media: atomisp: move a debug printf to a better place Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 3/7] media: atomisp: fix VIDIOC_S_FMT logic Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 4/7] media: atomisp: fix enum_fmt logic Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 5/7] media: atomisp: move atomisp_g_fmt_cap() Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 6/7] media: atomisp: fix try_fmt logic Mauro Carvalho Chehab
2021-11-04 12:05 ` [PATCH 7/7] media: atomisp: fix g_fmt logic Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1636026959.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox