Re: [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

Rob Herring
2021-11-12T14:47:56Z

On Thu, Nov 11, 2021 at 08:57:26AM -0600, Rob Herring wrote:
> On Wed, 10 Nov 2021 20:43:28 +0100, H. Nikolaus Schaller wrote:
> > From: Sam Ravnborg <sam@ravnborg.org>
> >
> > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> > Based on .txt binding from Zubair Lutfullah Kakakhel
> >
> > We also add add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > ---
> > .../display/bridge/synopsys,dw-hdmi.yaml | 3 +
> > .../bindings/display/ingenic-jz4780-hdmi.yaml | 76 +++++++++++++++++++

This goes in display/bridge/. And use compatible string for the file
name: ingenic,jz4780-hdmi.yaml

> > 2 files changed, 79 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.example.dt.yaml: hdmi@10180000: 'clock-names', 'ddc-i2c-bus', 'interrupt-parent', 'interrupts', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml

I think you need to use 'unevaluatedPropertes' instead of
'additionalProperties' if you are getting these properties from
synopsys,dw-hdmi.yaml.

Rob