From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Karolina Drobnik <karolinadrobnik@gmail.com>
Subject: [PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn`
Date: Mon, 15 Nov 2021 10:55:41 +0000 [thread overview]
Message-ID: <cover.1636729147.git.karolinadrobnik@gmail.com> (raw)
This patch set is a series of small refactorings of the function
`RFvWriteWakeProgSyn`, now renamed to `rf_write_wake_prog_syn`.
The work here allowed to shorten lines marked by checkpatch.pl as
being too long by:
* introducing two new temporary variables (`idx` and `init_table`)
* rewriting a conditional to switch between two modes of
AL7320 initialization.
In addition to this, the patch set renames the function to align it with
the kernel coding style, updates the function description and removes two
unnecessary conditionals checking if the value of `init_count` is lower than
a predefined value.
Changes in v3:
* add a patch for removing the type cast as a first change, suggested by
Dan Carpenter <dan.carpenter@oracle.com>
* merge two patches (using incrementation in `idx` and cleanup) into one,
partially implementing Dan's suggestion
Changes in v2:
* drop "staging: vt6655: Introduce `data` temporary variable" patch, suggested
by Julia Lawall <julia.lawall@inria.fr>
* amend "staging: vt6655: Rewrite conditional in AL7320 initialization" patch
to use indexing and `init_table` temporary variable
* add two new patches to remove unnecessary checks for init count, suggested
by Mike Rapoport <mike.rapoport@gmail.com>:
- "staging: vt6655: Delete bogus check for `init_count` in AL2230"
- "staging: vt6655: Delete bogus check for `init_count` in AL7230"
Karolina Drobnik (8):
staging: vt6655: Remove unnecessary type casts
staging: vt6655: Introduce `idx` variable
staging: vt6655: Use incrementation in `idx`
staging: vt6655: Rewrite conditional in AL7320 initialization
staging: vt6655: Rename `RFvWriteWakeProgSyn` function
staging: vt6655: Update comment for `rf_write_wake_prog_syn`
staging: vt6655: Delete bogus check for `init_count` in AL2230
staging: vt6655: Delete bogus check for `init_count` in AL7230
drivers/staging/vt6655/channel.c | 2 +-
drivers/staging/vt6655/rf.c | 44 +++++++++++++-------------------
drivers/staging/vt6655/rf.h | 2 +-
3 files changed, 20 insertions(+), 28 deletions(-)
--
2.30.2
next reply other threads:[~2021-11-15 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 10:55 Karolina Drobnik [this message]
2021-11-15 10:55 ` [PATCH v3 1/8] staging: vt6655: Remove unnecessary type casts Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 2/8] staging: vt6655: Introduce `idx` variable Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 3/8] staging: vt6655: Use incrementation in `idx` Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 4/8] staging: vt6655: Rewrite conditional in AL7320 initialization Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 5/8] staging: vt6655: Rename `RFvWriteWakeProgSyn` function Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 6/8] staging: vt6655: Update comment for `rf_write_wake_prog_syn` Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 7/8] staging: vt6655: Delete bogus check for `init_count` in AL2230 Karolina Drobnik
2021-11-15 10:55 ` [PATCH v3 8/8] staging: vt6655: Delete bogus check for `init_count` in AL7230 Karolina Drobnik
2021-11-15 15:47 ` [PATCH v3 0/8] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1636729147.git.karolinadrobnik@gmail.com \
--to=karolinadrobnik@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox