Re: [PATCH v9 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

Rob Herring
2021-11-30T18:20:52Z

On Tue, Nov 30, 2021 at 11:03 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Hi Rob,
>
> > Am 25.11.2021 um 22:26 schrieb Rob Herring <robh@kernel.org>:
> >
> > On Wed, 24 Nov 2021 22:29:09 +0100, H. Nikolaus Schaller wrote:
> >> From: Sam Ravnborg <sam@ravnborg.org>
> >>
> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> >> Based on .txt binding from Zubair Lutfullah Kakakhel
> >>
> >> We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml
> >>
> >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> Cc: Rob Herring <robh@kernel.org>
> >> Cc: devicetree@vger.kernel.org
> >> ---
> >> .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 +++++++++++++++++++
> >> .../display/bridge/synopsys,dw-hdmi.yaml | 3 +
> >> 2 files changed, 79 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/dtschema/schemas/bridge/bridge/synopsys,dw-hdmi.yaml'
>
> I wasn't able to fix that.
>
> If I change
>
> allOf:
> - - $ref: bridge/synopsys,dw-hdmi.yaml#
> + - $ref: synopsys,dw-hdmi.yaml#

That is correct.

>
> then make dt_binding_check still reports:
>
> Unknown file referenced: [Errno 2] No such file or directory: '/Users/hns/Library/Python/3.7/lib/python/site-packages/dtschema/schemas/bridge/synopsys,dw-hdmi.yaml'

The $id is wrong:

$id: http://devicetree.org/schemas/bridge/ingenic,jz4780-hdmi.yaml#

The path should be:
http://devicetree.org/schemas/display/bridge/ingenic,jz4780-hdmi.yaml#

Rob