[GIT PULL] Btrfs fixes for 5.16-rc3

[GIT PULL] Btrfs fixes for 5.16-rc3

[David Sterba]

Hi,

one more fix to the lzo code, a missing put_page causing memory leaks
when some error branches are taken.

Please pull, thanks.

----------------------------------------------------------------
The following changes since commit 6c405b24097c24cbb11570b47fd382676014f72e:

  btrfs: deprecate BTRFS_IOC_BALANCE ioctl (2021-11-16 16:51:19 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag

for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a:

  btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100)

----------------------------------------------------------------
Qu Wenruo (1):
      btrfs: fix the memory leak caused in lzo_compress_pages()

 fs/btrfs/lzo.c | 2 ++
 1 file changed, 2 insertions(+)

Re: [GIT PULL] Btrfs fixes for 5.16-rc3

[Linus Torvalds]

On Fri, Nov 26, 2021 at 7:42 AM David Sterba <dsterba@suse.com> wrote:
>
> one more fix to the lzo code, a missing put_page causing memory leaks
> when some error branches are taken.
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag

Hmm.

pr-tracker-bot didn't react to this one, and it wasn't obvious why.

Until I started looking closer. You claim:

> for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a:
>
>   btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100)

but in fact it's commit daf87e953527, not as the pull request claims
504d851ab360..

And no, it's not the tag either, that was d0a295f521e2.

The diffstat and the shortlog matched, so I had pulled it without
noticing. But something went wrong in there in the pull request.

               Linus

Re: [GIT PULL] Btrfs fixes for 5.16-rc3

[David Sterba]

On Fri, Nov 26, 2021 at 12:48:15PM -0800, Linus Torvalds wrote:
> On Fri, Nov 26, 2021 at 7:42 AM David Sterba <dsterba@suse.com> wrote:
> >
> > one more fix to the lzo code, a missing put_page causing memory leaks
> > when some error branches are taken.
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag
> 
> Hmm.
> 
> pr-tracker-bot didn't react to this one, and it wasn't obvious why.
> 
> Until I started looking closer. You claim:
> 
> > for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a:
> >
> >   btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100)
> 
> but in fact it's commit daf87e953527, not as the pull request claims
> 504d851ab360..
> 
> And no, it's not the tag either, that was d0a295f521e2.
> 
> The diffstat and the shortlog matched, so I had pulled it without
> noticing. But something went wrong in there in the pull request.

Possible explanation: I had problems pushing to k.org repo from work
machine (ssh timeout, fetching worked) so I pushed it from a different
one. The branch to pull was recreated from the same commit, with id
daf87e953527b03c0b and pushed to k.org but I must have kept the previous
for-5.16-rc2 branch without update when preparing the pull request mail.