public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Abdun Nihaal <abdun.nihaal@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Abdun Nihaal <abdun.nihaal@gmail.com>,
	Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	straube.linux@gmail.com, martin@kaiser.cx,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] staging: r8188eu: remove unneeded ret variables
Date: Thu,  6 Jan 2022 23:11:50 +0530	[thread overview]
Message-ID: <cover.1641490034.git.abdun.nihaal@gmail.com> (raw)

This patchset removes unneeded return variables in ioctl_linux.c,
and also converts functions that always return 0 to return void.

v1 -> v2:

- As suggested by Greg, change functions that always return 0
  and whose return value is not used, to return void instead.
- Not removing return variables in rtw_p2p_get2 and rtw_p2p_set
  as they may need to be used.
  These functions call other functions that do return error codes
  (mostly -1 and -EFAULT) but are not propagated back.
  I'll send a different patch to fix that.

Abdun Nihaal (2):
  staging: r8188eu: remove unneeded ret variables
  staging: r8188eu: change functions to return void

 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 156 ++++++++-----------
 1 file changed, 68 insertions(+), 88 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-01-06 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 17:41 Abdun Nihaal [this message]
2022-01-06 17:41 ` [PATCH v2 1/2] staging: r8188eu: remove unneeded ret variables Abdun Nihaal
2022-01-06 17:41 ` [PATCH v2 2/2] staging: r8188eu: change functions to return void Abdun Nihaal
2022-01-06 17:58   ` Greg KH
2022-01-07  6:52     ` Abdun Nihaal
2022-01-07  8:58       ` Dan Carpenter
2022-01-07  9:55         ` Abdun Nihaal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1641490034.git.abdun.nihaal@gmail.com \
    --to=abdun.nihaal@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox