Re: [PATCH v2 1/4] scripts/get_feat.pl: allow output the parsed file names

Jonathan Corbet
2022-03-25T19:39:39Z

Mauro Carvalho Chehab <mchehab@kernel.org> writes:

> Such output could be helpful while debugging it, but its main
> goal is to tell kernel_feat.py about what files were used
> by the script. Thie way, kernel_feat.py can add those as
> documentation dependencies.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

So I think these are worth getting into 5.18, but I do have one question:

> @@ -95,6 +97,10 @@ sub parse_feat {
> return if ($file =~ m,($prefix)/arch-support.txt,);
> return if (!($file =~ m,arch-support.txt$,));
>
> + if ($enable_fname) {
> + printf "#define FILE %s\n", abs_path($file);
> + }
> +

Why do you output the file names in this format? This isn't input to
the C preprocessor, so the #define just seems strange. What am I
missing here?

Thanks,

jon