Re: [PATCH v2 2/4] staging: r8188eu: add error handling of rtw_read16

Pavel Skripkin
2022-06-06T19:01:18Z

Hi Greg,

On 6/6/22 08:48, Greg KH wrote:
>> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> index e67ecbd1ba79..6662ebc30f7b 100644
>> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> @@ -249,11 +249,14 @@ static void efuse_read_phymap_from_txpktbuf(
>> hi32 = cpu_to_le32(rtw_read32(adapter, REG_PKTBUF_DBG_DATA_H));
>>
>> if (i == 0) {
>> + u16 reg;
>> +
>> /* Although lenc is only used in a debug statement,
>> * do not remove it as the rtw_read16() call consumes
>> * 2 bytes from the EEPROM source.
>> */
>> - rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L);
>> + res = rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L, &reg);
>> + (void)res;
>
> Same here, that line isn't ok.
>
hm, that place is not obvious.

I guess, on-chip EEPROM acts like a FIFO, so this read must be completed
w/o any errors, so I will simply propagate an error to callers

And will place another "FIXME" for further work :)

thanks,

With regards,
Pavel Skripkin