From: Sander Vanheule <sander@svanheule.net>
To: Peter Zijlstra <peterz@infradead.org>,
Yury Norov <yury.norov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Valentin Schneider <vschneid@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marco Elver <elver@google.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sander Vanheule <sander@svanheule.net>
Subject: [PATCH v3 0/4] cpumask: Fix invalid uniprocessor assumptions
Date: Sun, 5 Jun 2022 08:22:37 +0200 [thread overview]
Message-ID: <cover.1654410109.git.sander@svanheule.net> (raw)
On uniprocessor builds, it is currently assumed that any cpumask will
contain the single CPU: cpu0. This assumption is used to provide
optimised implementations.
The current assumption also appears to be wrong, by ignoring the fact
that users can provide empty cpumask-s. This can result in bugs as
explained in [1].
This series introduces some basic tests, and updates the optimisations
for uniprocessor builds.
[1] https://lore.kernel.org/all/20220530082552.46113-1-sander@svanheule.net/
Changes since v2:
Link: https://lore.kernel.org/all/cover.1654362935.git.sander@svanheule.net/
- Put new tests after patch fixes
- Update for_each_* macros
Changes since v1:
Link: https://lore.kernel.org/all/cover.1654201862.git.sander@svanheule.net/
- Place tests in lib/test_cpumask.c
- Drop the modified UP code in favor of the generic SMP implementation
- Update declaration of cpumask_next_wrap()
Sander Vanheule (4):
cpumask: Fix invalid uniprocessor mask assumption
lib/test: Introduce cpumask KUnit test suite
cpumask: Add UP optimised for_each_*_cpu versions
cpumask: Update cpumask_next_wrap() signature
include/linux/cpumask.h | 89 +++------------------------
lib/Kconfig.debug | 9 +++
lib/Makefile | 4 +-
lib/test_cpumask.c | 132 ++++++++++++++++++++++++++++++++++++++++
4 files changed, 151 insertions(+), 83 deletions(-)
create mode 100644 lib/test_cpumask.c
--
2.36.1
next reply other threads:[~2022-06-05 6:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 6:22 Sander Vanheule [this message]
2022-06-05 6:22 ` [PATCH v3 1/4] cpumask: Fix invalid uniprocessor mask assumption Sander Vanheule
2022-06-06 0:48 ` kernel test robot
2022-06-06 10:40 ` Andy Shevchenko
2022-06-08 17:59 ` Sander Vanheule
2022-06-06 19:14 ` Yury Norov
2022-06-07 12:06 ` Sander Vanheule
2022-06-05 6:22 ` [PATCH v3 2/4] lib/test: Introduce cpumask KUnit test suite Sander Vanheule
2022-06-05 6:31 ` Sander Vanheule
2022-06-06 10:36 ` Andy Shevchenko
2022-06-06 12:22 ` Sander Vanheule
2022-06-05 6:22 ` [PATCH v3 3/4] cpumask: Add UP optimised for_each_*_cpu versions Sander Vanheule
2022-06-05 6:22 ` [PATCH v3 4/4] cpumask: Update cpumask_next_wrap() signature Sander Vanheule
2022-06-06 10:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1654410109.git.sander@svanheule.net \
--to=sander@svanheule.net \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).