Re: [PATCH v2 02/19] KVM: x86: Use this_cpu_ptr() instead of per_cpu_ptr(smp_processor_id())

Chao Gao
2022-09-01T05:56:57Z

On Tue, Aug 30, 2022 at 05:01:17AM -0700, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>convert per_cpu_ptr(smp_processor_id()) to this_cpu_ptr() as trivial
>cleanup.
>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>

>---
> arch/x86/kvm/x86.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index 16104a2f7d8e..7d5fff68befe 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -416,8 +416,7 @@ EXPORT_SYMBOL_GPL(kvm_find_user_return_msr);
>
> int kvm_set_user_return_msr(unsigned slot, u64 value, u64 mask)
> {
>- unsigned int cpu = smp_processor_id();
>- struct kvm_user_return_msrs *msrs = per_cpu_ptr(user_return_msrs, cpu);
>+ struct kvm_user_return_msrs *msrs = this_cpu_ptr(user_return_msrs);
> struct kvm_user_return_msr_values *values = &msrs->values[slot];
> int err;
>
>@@ -449,8 +448,7 @@ EXPORT_SYMBOL_GPL(kvm_set_user_return_msr);
>
> static void drop_user_return_notifiers(void)
> {
>- unsigned int cpu = smp_processor_id();
>- struct kvm_user_return_msrs *msrs = per_cpu_ptr(user_return_msrs, cpu);
>+ struct kvm_user_return_msrs *msrs = this_cpu_ptr(user_return_msrs);
>
> if (msrs->registered)
> kvm_on_user_return(&msrs->urn);
>--
>2.25.1
>