public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Deepak R Varma <drv@mailo.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Saurabh Singh Sengar <ssengar@microsoft.com>,
	Praveen Kumar <kumarpraveen@linux.microsoft.com>,
	Deepak R Varma <drv@mailo.com>
Subject: [PATCH v2 0/2] convert i915_active.count from atomic_t to refcount_t
Date: Sun, 25 Dec 2022 13:15:33 +0530	[thread overview]
Message-ID: <cover.1671952191.git.drv@mailo.com> (raw)

Transition the reference count member variable count of struct i915_active from
atomic_t type to refcount_t type. This proposal is based on issues identified
using the atomic_as_refcounter.cocci Coccinelle semantic patch script.

Patch 1/2: proposes to convert the base implementation of variable count from
	   atomic_t to refcount_t. This also includes the transition of
	   atomic_*() API calls to their equivalent refcount_*() API calls.

Patch 2/2: proposes to transition the atomic_*() API calls in i915 selftest
	   use cases to their equivalent refcount_*() API calls.

Please Note:
   1. Patch 1/2 should be applied before patch 2/2 due to interdependency.
   2. I did not enable to the selftest and debug configurations earlier while
      building the i915 base driver. With the build failures reported by the
      Kernel Test Robot, I have now included those changes. I did not find any
      other configurations that required additional atomic_* API call transition
      for this member variable of struct i915_active. Please let me know if there
      are other related disabled configurations that I should be enable for
      additional code coverage.
   3. Any guidance on working with i915/selftests would be very helpful for my
      learning.

Changes in v2:
   1. Patch series introduced.
   2. Handle build issues Reported-by: kernel test robot <lkp@intel.com>
      Earlier a standalone patch was sent for the i915 base driver only. The
      Kernel Test Robot reported failure for additional atomic_*() calls specific
      to i915 debugging support when enabled. This version now includes those
      changes as well.
   3. Handle build issues Reported-by: kernel test robot <lkp@intel.com> for i915/selftests
      Include changes for i915/selftests use cases for atomic_* to refcount_*
      transition.


Deepak R Varma (2):
  drm/i915: convert i915_active.count from atomic_t to refcount_t
  drm/i915/selftests: Convert atomic_* API calls for i915_active.count
    refcount_*

 drivers/gpu/drm/i915/i915_active.c           | 28 +++++++++++---------
 drivers/gpu/drm/i915/i915_active.h           |  6 ++---
 drivers/gpu/drm/i915/i915_active_types.h     |  4 +--
 drivers/gpu/drm/i915/selftests/i915_active.c |  8 +++---
 4 files changed, 24 insertions(+), 22 deletions(-)

--
2.34.1




             reply	other threads:[~2022-12-25  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25  7:45 Deepak R Varma [this message]
2022-12-25  7:47 ` [PATCH v2 1/2] drm/i915: convert i915_active.count from atomic_t to refcount_t Deepak R Varma
2022-12-28 11:58   ` kernel test robot
2022-12-28 14:43   ` Praveen Kumar
2022-12-25  7:48 ` [PATCH v2 2/2] drm/i915/selftests: Convert atomic_* API calls for i915_active.count refcount_* Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1671952191.git.drv@mailo.com \
    --to=drv@mailo.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kumarpraveen@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=ssengar@microsoft.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox