public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakob Hauser <jahau@rocketmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Lee Jones <lee@kernel.org>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
	Stephan Gerhold <stephan@gerhold.net>,
	Raymond Hackley <raymondhackley@protonmail.com>,
	Henrik Grimler <henrik@grimler.se>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Jakob Hauser <jahau@rocketmail.com>
Subject: [PATCH 0/2] Clean-up RT5033 charger "rt5033_charger_data" and probe "&pdev->dev"
Date: Fri, 16 Jun 2023 23:10:46 +0200	[thread overview]
Message-ID: <cover.1686948074.git.jahau@rocketmail.com> (raw)
In-Reply-To: cover.1686948074.git.jahau.ref@rocketmail.com

During the review of the series "Add RT5033 charger device driver" [1] I
noticed two things I'd like to clean up. Additionally, in v5 of that series,
Christophe Jaillet pointed out an unclean error handling of function
"rt5033_charger_data" [2]. The clean-up solves this as well. As I didn't want
to disturb the review process of the series in its late phase, I now add these
clean-ups as a follow-up series.

I was a bit surprised about the patchset "Add RT5033 charger device driver"
being added via the mfd subsystem. This clean-up series affects the charger
driver, which is actually part of the power supply subsystem. I'm not
fully sure what the series should be based on and how it will be applied
best.

Additionally I just realized that in the immutable branch "ib-mfd-power-v6.5"
of kernel/git/lee/mfd.git one patch of the previous series is missing. Because
of this, I currently can't use linux-next or mfd.git as a base. Instead I based
this clean-up patchset right on top of the previous patchset. An instance of
that base can be seen on my GitHub page [3][4].

[1] https://lore.kernel.org/linux-pm/cover.1684182964.git.jahau@rocketmail.com/T/#u
[2] https://lore.kernel.org/linux-pm/20230514123130.41172-1-jahau@rocketmail.com/T/#mbe33ab528f3d8ae136f01b13f45a9be35c0ad061
[3] https://github.com/Jakko3/linux/commits/rt5033-charger_v6
[4] https://github.com/Jakko3/linux/blob/rt5033-charger_v6/drivers/power/supply/rt5033_charger.c

Jakob Hauser (2):
  power: supply: rt5033_charger: Simplify initialization of
    rt5033_charger_data
  power: supply: rt5033_charger: Replace "&pdev->dev" by "charger->dev"
    in probe

 drivers/power/supply/rt5033_charger.c | 43 ++++++++++++---------------
 1 file changed, 19 insertions(+), 24 deletions(-)

-- 
2.39.2


       reply	other threads:[~2023-06-16 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1686948074.git.jahau.ref@rocketmail.com>
2023-06-16 21:10 ` Jakob Hauser [this message]
2023-06-16 21:10   ` [PATCH 1/2] power: supply: rt5033_charger: Simplify initialization of rt5033_charger_data Jakob Hauser
2023-06-16 21:10   ` [PATCH 2/2] power: supply: rt5033_charger: Replace "&pdev->dev" by "charger->dev" in probe Jakob Hauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1686948074.git.jahau@rocketmail.com \
    --to=jahau@rocketmail.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=henrik@grimler.se \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=raymondhackley@protonmail.com \
    --cc=sre@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox