* [PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings
@ 2023-10-12 12:50 Soumya Negi
2023-10-13 7:46 ` Soumya Negi
0 siblings, 1 reply; 2+ messages in thread
From: Soumya Negi @ 2023-10-12 12:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Micky Ching
Cc: Soumya Negi, outreachy, linux-staging, linux-kernel
In the driver staging/rts5208, checkpatch.pl warns of possible precedence
issues in the header rtsx.h because macro arguments are not parenthesized.
This patch set handles the respective macros differently(as needed) in
each patch to fix the warnings. Patches can be applied in any order.
Soumya Negi (2):
staging: rts5208: Refactor macros to static inline functions
staging: rts5208: Remove macros scsi_lock(), scsi_unlock()
drivers/staging/rts5208/rtsx.c | 24 ++++++-------
drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
2 files changed, 52 insertions(+), 38 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings
2023-10-12 12:50 [PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings Soumya Negi
@ 2023-10-13 7:46 ` Soumya Negi
0 siblings, 0 replies; 2+ messages in thread
From: Soumya Negi @ 2023-10-13 7:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Micky Ching; +Cc: outreachy, linux-staging, linux-kernel
On Thu, Oct 12, 2023 at 05:50:21AM -0700, Soumya Negi wrote:
> In the driver staging/rts5208, checkpatch.pl warns of possible precedence
> issues in the header rtsx.h because macro arguments are not parenthesized.
> This patch set handles the respective macros differently(as needed) in
> each patch to fix the warnings. Patches can be applied in any order.
>
> Soumya Negi (2):
> staging: rts5208: Refactor macros to static inline functions
> staging: rts5208: Remove macros scsi_lock(), scsi_unlock()
>
> drivers/staging/rts5208/rtsx.c | 24 ++++++-------
> drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
> 2 files changed, 52 insertions(+), 38 deletions(-)
Please ignore this patch set. Its incomplete & the rest of the patches
were not sent successfully. I have successfuly resent the complete
patchset(unchanged) as v2 with an explanation after --- in the cover patch.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-13 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12 12:50 [PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings Soumya Negi
2023-10-13 7:46 ` Soumya Negi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox