From: Soumya Negi <soumya.negi97@gmail.com>
To: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
julia.lawall@inria.fr, Andi Shyti <andi.shyti@kernel.org>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Soumya Negi <soumya.negi97@gmail.com>
Subject: [PATCH v3 0/5] staging: vme_user: Remove printk's & clean up log messages
Date: Thu, 19 Oct 2023 18:55:18 -0700 [thread overview]
Message-ID: <cover.1697763267.git.soumya.negi97@gmail.com> (raw)
Staging driver vme_user has a bunch of printk() calls in vme.c which
triggers checkpatch warnings. Remove all printk's by either changing
them to the appropriate logging mechanism i.e dev_err()/dev_warn() or
by dropping the unneeded printk's.
Also, clean up the messages further by using __func__ in the string
instead of function names.
This patchset fixes all checkpatch warnings like:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
&
WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
this function's name, in a string
Patches must be applied in order.
Changes in v3:
1. Patch 1: Use only dev_err() to replace printk(). v2 replaced some
of the printk's using pr_err(). Leave the calls as printk's. New
patches added in v3 handle these printk's.
(as per feedback from gregkh@linuxfoundation.org)
2. Added Patch 3: Remove unneeded printk.
(suggested by gregkh@linuxfoundation.org)
3. Added Patch 4: Remove NULL-checks for bridge device & resource.
Corresponding printk's(part of the check blocks) are removed too.
(as per feedback from gregkh@linuxfoundation.org)
4. Added Patch 5: Replace printk with dev_err() in vme_check_window()
Since vme_check_window() doesn't have access to bridge device, pass
the bridge pointer to it.
(suggested by gregkh@linuxfoundation.org)
5. Edit cover letter subject & body according to patches added in v3.
Changes in v2:
1. Correct "cleanup" to "clean up" in cover letter. (as per feedback
from julia.lawall@inria.fr)
2. Patch 1: Change the pr_*() calls used to replace printk's in v1 to
dev_*() wherever possible, as it adds more context to the messages.
(as per feedback from julia.lawall@inria.fr &
gregkh@linuxfoundation.org)
Soumya Negi (5):
staging: vme_user: Replace printk() with dev_*()
staging: vme_user: Use __func__ instead of function name
staging: vme_user: Remove printk() in find_bridge()
staging: vme_user: Remove NULL-checks
staging: vme_user: Use dev_err() in vme_check_window()
drivers/staging/vme_user/vme.c | 222 ++++++++++++++++-----------------
drivers/staging/vme_user/vme.h | 4 +-
2 files changed, 108 insertions(+), 118 deletions(-)
--
2.42.0
next reply other threads:[~2023-10-20 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:55 Soumya Negi [this message]
2023-10-20 1:55 ` [PATCH v3 1/5] staging: vme_user: Replace printk() with dev_*() Soumya Negi
2023-10-20 1:55 ` [PATCH v3 2/5] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-20 1:55 ` [PATCH v3 3/5] staging: vme_user: Remove printk() in find_bridge() Soumya Negi
2023-10-20 1:55 ` [PATCH v3 4/5] staging: vme_user: Remove NULL-checks Soumya Negi
2023-10-20 1:55 ` [PATCH v3 5/5] staging: vme_user: Use dev_err() in vme_check_window() Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1697763267.git.soumya.negi97@gmail.com \
--to=soumya.negi97@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox