From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: [PATCH v2 0/2] Document handing of unwritten bh in ext4_block_zero_page_range()
Date: Wed, 1 Nov 2023 22:08:09 +0530 [thread overview]
Message-ID: <cover.1698856309.git.ojaswin@linux.ibm.com> (raw)
** Changes v1 -> v2 **
* Instead of exiting early in ext4_block_zero_page_range() for unwrit
bhs like in v1, lets let the current logic be as it is and instead
document the handing of unwritten buffer heads to make the intent
clear
v1:
https://lore.kernel.org/linux-ext4/20231019165546.norapdphdyx7g3ob@quack3/T/#mbd0ab69d55487493edbd465b3882051e5bc2365d
** Original Cover Letter **
As per discussion with Jan here [1], this patchset intends to exit early
from __ext4_block_zero_page_range() incase the block we are about to
zero (partially) is unwritten and unmapped, since such a block doesn't
require zeroing.
Further, also make sure that calls to ext4_zero_partial_blocks()
truncate the page cache completely beforehand, so that they don't rely
on ext4_zero_partial_block() -> __ext4_block_zero_page_range() to zero
out non block aligned edges of pagecache.
Reviews and comments are appreciated!
Regards,
ojaswin
[1]
https://lore.kernel.org/linux-ext4/20230914141920.lw2nlpzhcxwuz2y6@quack3/
Ojaswin Mujoo (2):
ext4: treat end of range as exclusive in ext4_zero_range()
ext4: Clarify handling of unwritten bh in
__ext4_block_zero_page_range()
fs/ext4/extents.c | 6 ++++--
fs/ext4/inode.c | 6 ++++++
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.39.3
next reply other threads:[~2023-11-01 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 16:38 Ojaswin Mujoo [this message]
2023-11-01 16:38 ` [PATCH v2 1/2] ext4: treat end of range as exclusive in ext4_zero_range() Ojaswin Mujoo
2023-11-02 10:08 ` Jan Kara
2023-11-01 16:38 ` [PATCH v2 2/2] ext4: Clarify handling of unwritten bh in __ext4_block_zero_page_range() Ojaswin Mujoo
2023-11-02 10:08 ` Jan Kara
2024-01-09 2:53 ` [PATCH v2 0/2] Document handing of unwritten bh in ext4_block_zero_page_range() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1698856309.git.ojaswin@linux.ibm.com \
--to=ojaswin@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox