From: Krister Johansen <kjlx@templeofstupid.com>
To: Miklos Szeredi <miklos@szeredi.hu>, linux-fsdevel@vger.kernel.org
Cc: Miklos Szeredi <mszeredi@redhat.com>,
linux-kernel@vger.kernel.org,
German Maglione <gmaglione@redhat.com>,
Greg Kurz <groug@kaod.org>, Max Reitz <mreitz@redhat.com>,
Bernd Schubert <bernd.schubert@fastmail.fm>,
"Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
"Kurmi, Suresh Kumar" <suresh.kumar.kurmi@intel.com>,
"Saarinen, Jani" <jani.saarinen@intel.com>,
lkft-triage@lists.linaro.org, linux-kselftest@vger.kernel.org,
regressions@lists.linux.dev, intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/2] Fuse submount_lookup needs to be initialized
Date: Thu, 9 Nov 2023 14:36:57 -0800 [thread overview]
Message-ID: <cover.1699564053.git.kjlx@templeofstupid.com> (raw)
Hi Miklos,
I got a couple of bug reports[1][2] this morning from teams that are
tracking regresssions in linux-next. My patch 513dfacefd71 ("fuse:
share lookup state between submount and its parent") is causing panics
in the fuse unmount path. The reports came from users with SLUB_DEBUG
enabled, and the additional debug sanitization catches the fact that the
submount_lookup field isn't getting initialized which could lead to a
subsequently bogus attempt to access the submount_lookup structure and
adjust its refcount.
I've added SLUB_DEBUG to my testing kconfig, and have reproduced the
problem using the memfd self-test that was triggering the problem for
both reporters. With the fix that follows this e-mail, I see no more
erroneous accesses of poisoned slub memory.
I'm a bit unsure of the desired approach for fixing these kinds of
problems. I'm also away from the office on Nov 10th and Nov 13th, but
expect to be back on the console on the Nov 14th. Given the gap, I've
prepared a pair of patches, but we only need one.
The first is simply a followup fix that addresses the problem in a
subsequent one-line commit.
If you'd rather revert the entire bad patch and go again, the second
patch in the series is a v5 of the original with the submount_lookup
initialization added.
Either should do, but I wasn't sure which approach was preferable.
Thanks, and my apologies for the inconvenience.
-K
[1] https://lore.kernel.org/linux-fsdevel/CA+G9fYue-dV7t-NrOhWwGshvyboXjb2B6HpCDVDe3bgG7fbnsg@mail.gmail.com/T/#u
[2] https://lore.kernel.org/intel-gfx/SJ1PR11MB6129508509896AD7D0E03114B9AFA@SJ1PR11MB6129.namprd11.prod.outlook.com/T/#u
next reply other threads:[~2023-11-09 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 22:36 Krister Johansen [this message]
2023-11-09 22:37 ` [PATCH 1/2] fuse: ensure submount_lookup is initialized on alloc Krister Johansen
2023-11-09 22:37 ` [v5 PATCH 2/2] fuse: share lookup state between submount and its parent Krister Johansen
2023-11-10 9:44 ` [PATCH 0/2] Fuse submount_lookup needs to be initialized Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1699564053.git.kjlx@templeofstupid.com \
--to=kjlx@templeofstupid.com \
--cc=bernd.schubert@fastmail.fm \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=gmaglione@redhat.com \
--cc=groug@kaod.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=miklos@szeredi.hu \
--cc=mreitz@redhat.com \
--cc=mszeredi@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=regressions@lists.linux.dev \
--cc=suresh.kumar.kurmi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox