From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Nishanth Menon <nm@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/3] OPP: Simplify required-opp handling
Date: Thu, 16 Nov 2023 16:13:04 +0530 [thread overview]
Message-ID: <cover.1700131353.git.viresh.kumar@linaro.org> (raw)
Hello,
Configuring the required OPP was never properly implemented, we just
took an exception for genpds and configured them directly, while leaving
out all other required OPP types.
Now that a standard call to dev_pm_opp_set_opp() takes care of
configuring the opp->level too, the special handling for genpds can be
avoided by simply calling dev_pm_opp_set_opp() for the required OPPs,
which shall eventually configure the corresponding level for genpds.
This also makes it possible for us to configure other type of required
OPPs (no concrete users yet though), via the same path. This is how
other frameworks take care of parent nodes, like clock, regulators, etc,
where we recursively call the same helper.
Pushed here:
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/required-opps
V2->V3:
- Dropped patch 1/3, merged.
- Added a new commit to avoid propagation and a WARN() for parent genpd case.
V1->V2:
- Support opp-level 0, drop vote i.e..
- Fix OPP pointer while calling dev_pm_opp_set_opp() recursively.
- Minor checks and fixes.
- Add Reviewed-by from Ulf.
--
Viresh
Viresh Kumar (3):
OPP: Use _set_opp_level() for single genpd case
OPP: Call dev_pm_opp_set_opp() for required OPPs
OPP: Don't set OPP recursively for a parent genpd
drivers/opp/core.c | 180 ++++++++++++++++++++++-------------------
drivers/opp/of.c | 49 ++++++++---
drivers/opp/opp.h | 8 +-
include/linux/pm_opp.h | 7 +-
4 files changed, 144 insertions(+), 100 deletions(-)
--
2.31.1.272.g89b43f80a514
next reply other threads:[~2023-11-16 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 10:43 Viresh Kumar [this message]
2023-11-16 10:43 ` [PATCH V3 1/3] OPP: Use _set_opp_level() for single genpd case Viresh Kumar
2023-11-16 10:43 ` [PATCH V3 2/3] OPP: Call dev_pm_opp_set_opp() for required OPPs Viresh Kumar
2023-11-16 10:43 ` [PATCH V3 3/3] OPP: Don't set OPP recursively for a parent genpd Viresh Kumar
2023-11-22 14:26 ` Ulf Hansson
2023-11-28 10:29 ` [PATCH V3 0/3] OPP: Simplify required-opp handling Stephan Gerhold
2023-11-28 10:34 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1700131353.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox