Re: [PATCH v2 0/4] ALSA: hda/tas2781: Add tas2563 support

Takashi Iwai
2023-12-31T08:33:46Z

On Sat, 30 Dec 2023 21:18:06 +0100,
Gergo Koteles wrote:
>
> Hi Takashi,
>
> On Sat, 2023-12-30 at 17:59 +0100, Takashi Iwai wrote:
> > Thanks, I guess I'll take this series later for 6.8 unless any
> > objection is raised from reviewers.
> >
> > But, I'd like to hear clarifications of some points beforehand:
> >
> > - Did we get consensus about the ACPI HID? I didn't follow the
> > previous thread completely.
> >
>
> The INT8866 is a (wrong) PNP ID, that should only be used by the owner
> "Interphase Corporation".
> Intel has also mistakenly used the INT PNP prefix in the past, and now
> TI/leNovo.

Yeah, and the question is whether TI / Lenovo recognize the problem
and will avoid such a failure in future again.

> > Since those models have been already in the market for quite some
> > time, we'd have to accept "INT8866", I'm afraid. But it's still
> > very important to know whether a similar problem can be avoided in
> > future.
> >
> > - Will be the firmware files upstreamed to linux-firmware tree later?
> > Otherwise users will have significant difficulties.
>
> Shenghao sent the two files to linux-firmware@kernel.org a few days
> ago, but I think the "Allegedly GPLv2+ ... Found in hex form in kernel
> source." Licence needs to be fixed before acceptance.

OK, that sounds promising.

> But even if it is not included in the linux-firmware package, it is
> easier for users to put two files in place per OS installation than
> patching the kernel.

Sure.

thanks,

Takashi