RE: [PATCH v3 2/2] tty/sysrq: Dump printk ring buffer messages via sysrq

David Laight
2024-01-18T22:57:19Z

From: Sreenath Vijayan
> Sent: 17 January 2024 11:14
....
> /* Key Operations table and lock */
> static DEFINE_SPINLOCK(sysrq_key_table_lock);
>
> @@ -505,7 +523,7 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
> NULL, /* A */
> NULL, /* B */
> NULL, /* C */
> - NULL, /* D */
> + &sysrq_dmesg_dump_op, /* D */
> NULL, /* E */
> NULL, /* F */
> NULL, /* G */

That looks like it ought to use C99 initialisers:
['D' - 'A'] = &sysrq_dmesg_dump_op,

Possible with a #define to hide the offset.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)