public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Duncan <leeman.duncan@gmail.com>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Chengfeng Ye <dg573847474@gmail.com>,
	hare@suse.de, Satish Kharat <satishkh@cisco.com>,
	Sesidhar Baddela <sebaddel@cisco.com>,
	Karan Tilak Kumar <kartilak@cisco.com>,
	Lee Duncan <lduncan@suse.com>
Subject: [PATCH v4 0/2] Ensure FCoE target interrupts work correctly
Date: Fri,  9 Feb 2024 10:07:33 -0800	[thread overview]
Message-ID: <cover.1707500786.git.lduncan@suse.com> (raw)

From: Lee Duncan <lduncan@suse.com>

Commit 1a1975551943 "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"
changed locking for fnic/FCoE, but it did so by disabling interrupts
where they weren't disabled before, and this caused FCoE targets
to go offline. Reverting that patch fixed the issue.

But to handle the problem originally addressed by the commit,
instead of modifying the locking, move the work to be done
into a work queue.

Differences in v4:
  - Corrected "Fixes" attributes in both patches
  - Added identifier name in fnic_flush_tx() prototype, for checkpatch

Differences in v3:
  - Added "fixes" clause to the fnic patch, as requested by Hannes

Differences in V2:
  - Fix kerneldoc comments in fnic_flush_tx()

Lee Duncan (1):
  Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

Hannes Reinecke (1):
  fnic: move fnic_fnic_flush_tx() to a work queue

 drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------
 drivers/scsi/fnic/fnic.h      |  3 ++-
 drivers/scsi/fnic/fnic_fcs.c  |  5 +++--
 drivers/scsi/fnic/fnic_main.c |  1 +
 drivers/scsi/fnic/fnic_scsi.c |  4 ++--
 5 files changed, 16 insertions(+), 17 deletions(-)

-- 
2.35.3


             reply	other threads:[~2024-02-09 18:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 18:07 Lee Duncan [this message]
2024-02-09 18:07 ` [PATCH v4 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" Lee Duncan
2024-02-11 13:52   ` Hannes Reinecke
2024-02-09 18:07 ` [PATCH v4 2/2] fnic: move fnic_fnic_flush_tx() to a work queue Lee Duncan
2024-02-13  1:57 ` [PATCH v4 0/2] Ensure FCoE target interrupts work correctly Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1707500786.git.lduncan@suse.com \
    --to=leeman.duncan@gmail.com \
    --cc=dg573847474@gmail.com \
    --cc=hare@suse.de \
    --cc=kartilak@cisco.com \
    --cc=lduncan@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox