Re: [PATCH net 2/2] selftests: mptcp: explicitly trigger the listener diag code-path

Paolo Abeni
2024-02-21T15:19:25Z

On Wed, 2024-02-21 at 12:46 +0100, Paolo Abeni wrote:
> The mptcp diag interface already experienced a few locking bugs
> that lockdep and appropriate coverage have detected in advance.
>
> Let's add a test-case triggering the relevant code path, to prevent
> similar issues in the future.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> tools/testing/selftests/net/mptcp/diag.sh | 30 +++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/selftests/net/mptcp/diag.sh
> index 60a7009ce1b5..3ab584b38566 100755
> --- a/tools/testing/selftests/net/mptcp/diag.sh
> +++ b/tools/testing/selftests/net/mptcp/diag.sh
> @@ -81,6 +81,21 @@ chk_msk_nr()
> __chk_msk_nr "grep -c token:" "$@"
> }
>
> +chk_listener_nr()
> +{
> + local expected=$1
> + local msg="$2"
> +
> + if [ $expected -gt 0 ] && \
> + ! mptcp_lib_kallsyms_has "mptcp_diag_dump_listeners"; then
> + printf "%-50s%s\n" "$msg - mptcp" "[ skip ]"
> + mptcp_lib_result_skip "many listener sockets"

I was too hasty and this is too fragile/requires debug. A v2 with
something more reliable is needed. Given this is not going to land into
this week PR, we will probably send it with a burst with other fixes.

Thanks,

Paolo