Re: [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD

Ilpo Järvinen
2024-04-26T07:06:46Z

On Thu, 25 Apr 2024, Babu Moger wrote:

> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
> available on the system. Tests will be skipped otherwise.
>
> Update noncont_cat_run_test to check for vendor. AMD supports
> non contiguous CBM masks but does not report it via CPUID.
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> tools/testing/selftests/resctrl/cat_test.c | 2 +-
> tools/testing/selftests/resctrl/mba_test.c | 1 -
> tools/testing/selftests/resctrl/mbm_test.c | 1 -
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 4cb991be8e31..b682eaf65bfd 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -314,7 +314,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test,
> else
> return -EINVAL;
>
> - if (sparse_masks != ((ecx >> 3) & 1)) {
> + if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) {

This looks independent change to me which should be put into own patch.

--
i.

> ksft_print_msg("CPUID output doesn't match 'sparse_masks' file content!\n");
> return 1;
> }
> diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
> index 7946e32e85c8..353054724fa7 100644
> --- a/tools/testing/selftests/resctrl/mba_test.c
> +++ b/tools/testing/selftests/resctrl/mba_test.c
> @@ -177,7 +177,6 @@ static bool mba_feature_check(const struct resctrl_test *test)
> struct resctrl_test mba_test = {
> .name = "MBA",
> .resource = "MB",
> - .vendor_specific = ARCH_INTEL,
> .feature_check = mba_feature_check,
> .run_test = mba_run_test,
> };
> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
> index d67ffa3ec63a..f2223315b5b8 100644
> --- a/tools/testing/selftests/resctrl/mbm_test.c
> +++ b/tools/testing/selftests/resctrl/mbm_test.c
> @@ -147,7 +147,6 @@ static bool mbm_feature_check(const struct resctrl_test *test)
> struct resctrl_test mbm_test = {
> .name = "MBM",
> .resource = "MB",
> - .vendor_specific = ARCH_INTEL,
> .feature_check = mbm_feature_check,
> .run_test = mbm_run_test,
> };
>