Re: [PATCH 1/2] PCI: shpchp: Remove hpc_ops

ngn
2024-07-13T09:15:11Z

On Fri, Jul 12, 2024 at 05:44:25PM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 21, 2024 at 09:35:00AM +0300, ngn wrote:
> > fix checpatch warnings and call hpc_ops functions directly, this has been
> > also done in pciehp with commit 82a9e79ef132
>
> Trivial changes like checkpatch fixes should be in a separate patch
> from substantive things. This helps make both easier to review.
>
> It *might* be worthwhile to remove hpc_ops, although shpchp is pretty
> old and dusty by now, and it's hard to justify touching things like
> that because the risk of breaking something is relatively high and the
> benefit is relatively low.
>
> The fact that shpchp is the only user of hpc_ops does make me a little
> more sympathetic to the idea of removing it, though.
>

Thanks for the reply! I'll just remove hpc_ops then, and I'll send a separate
patch.