From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linus.walleij@linaro.org, sre@kernel.org, jic23@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/3] power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug
Date: Sat, 22 Jun 2024 09:04:23 +0200 [thread overview]
Message-ID: <cover.1719037737.git.christophe.jaillet@wanadoo.fr> (raw)
This series is inspired by a patch submitted at [1].
While looking if the same pattern was relevant elsewhere, I ended in
ab8500_charger.c.
Patch 1 fixes what looks to me as a regression introduced by
97ab78bac5d0.
Patch 2 is the initial goal of this series. That is to change some
iio_read_channel_processed() + multiplication by a single, cleaner,
iio_read_channel_processed_scale().
Patch 3 is a cosmetic change spotted while at it.
Honestly, I don't have a strong opinion if patch 2 helps in any way
(explanation or confirmation would be appreciated for my own
knowledge), but at least patch 1 deserves a look and seems value to me.
CJ
[1]: https://lore.kernel.org/all/20240620212005.821805-1-sean.anderson@linux.dev/
Christophe JAILLET (3):
power: supply: ab8500: Fix error handling when calling
iio_read_channel_processed()
power: supply: ab8500: Use iio_read_channel_processed_scale()
power: supply: ab8500: Clean some error messages
drivers/power/supply/ab8500_charger.c | 52 ++++++++++++++++-----------
1 file changed, 32 insertions(+), 20 deletions(-)
--
2.45.2
next reply other threads:[~2024-06-22 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 7:04 Christophe JAILLET [this message]
2024-06-22 7:04 ` [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel_processed() Christophe JAILLET
2024-06-23 17:16 ` Jonathan Cameron
2024-06-26 10:38 ` Linus Walleij
2024-06-22 7:04 ` [PATCH 2/3] power: supply: ab8500: Use iio_read_channel_processed_scale() Christophe JAILLET
2024-06-23 17:18 ` Jonathan Cameron
2024-06-26 10:39 ` Linus Walleij
2024-06-22 7:04 ` [PATCH 3/3] power: supply: ab8500: Clean some error messages Christophe JAILLET
2024-06-23 17:19 ` Jonathan Cameron
2024-06-26 10:39 ` Linus Walleij
2024-06-26 13:06 ` [PATCH 0/3] power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1719037737.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).