From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
James Morse <james.morse@arm.com>, Len Brown <lenb@kernel.org>,
Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] Add other fields to ARM trace event
Date: Thu, 27 Jun 2024 12:36:06 +0200 [thread overview]
Message-ID: <cover.1719484498.git.mchehab+huawei@kernel.org> (raw)
This series was originally sent at:
https://lore.kernel.org/all/20240321-b4-arm-ras-error-vendor-info-v5-rc3-v5-0-850f9bfb97a8@os.amperecomputing.com/
Those patches that fix UEFI 2.6+ implementation of the ARM trace event,
as the original implementation was incomplete.
In summary:
changeset e9279e83ad1f ("trace, ras: add ARM processor error trace event")
was incomplete: it added a trace event that was reporting only some fields
of the CPER record generated for ARM processor from UEFI 2.6 spec.
Those are not enough there to actually parse such events on userspace,
for it to properly report/record the error nor to take appropriate measures
to prevent future problems, like poisoning problematic CPU cores and taking
them offline.
The patch was validated with the help of an ARM EINJ code for QEMU:
https://github.com/mchehab/rasdaemon/wiki/error-injection
I tested the ghes and cper reports both with and without this change,
using different versions of rasdaemon, with and without support for
the extended trace event. Those are a summary of the test results:
- adding more fields to the trace events didn't break userspace API:
both versions of rasdaemon handled it;
- the rasdaemon patches to handle the new trace report was missing
a backward-compatibility logic. I fixed already. With that, rasdaemon
can handle both old and new trace events.
Btw, rasdaemon has gained support for the extended trace since its
version 0.5.8 (released in 2021). I didn't saw any issues there
complain about troubles on it, so either distros used on ARM servers
are using an old version of rasdaemon, or they're carrying on the trace
event changes as well.
---
- v2: fix a bad conflict resolution affecting non-arm compilation on patch 1.
- Changes over the original changeset:
- First patch was simplified to avoid too many #ifdefs;
- reordered local vars using reverse xmas tree;
- removed uneeded typecasts;
- some coding style fixes.
Daniel Ferguson (1):
RAS: ACPI: APEI: add conditional compilation to ARM error report
functions
Shengwei Luo (1):
RAS: Report all ARM processor CPER information to userspace
drivers/acpi/apei/ghes.c | 16 ++++++--------
drivers/ras/ras.c | 47 +++++++++++++++++++++++++++++++++++++--
include/linux/ras.h | 16 ++++++++++----
include/ras/ras_event.h | 48 +++++++++++++++++++++++++++++++++++-----
4 files changed, 107 insertions(+), 20 deletions(-)
--
2.45.2
next reply other threads:[~2024-06-27 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 10:36 Mauro Carvalho Chehab [this message]
2024-06-27 10:36 ` [PATCH v2 1/2] RAS: ACPI: APEI: add conditional compilation to ARM error report functions Mauro Carvalho Chehab
2024-07-01 14:14 ` Jonathan Cameron
2024-06-27 10:36 ` [PATCH v2 2/2] RAS: Report all ARM processor CPER information to userspace Mauro Carvalho Chehab
2024-06-27 13:28 ` Mauro Carvalho Chehab
2024-07-01 14:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1719484498.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox